Skip to content

docs(skill): correct the shape spellings and the motion-path claim - #193

Merged
LeadcodeDev merged 1 commit into
mainfrom
docs/skill-stale-claims
Aug 12, 2026
Merged

docs(skill): correct the shape spellings and the motion-path claim#193
LeadcodeDev merged 1 commit into
mainfrom
docs/skill-stale-claims

Conversation

@LeadcodeDev

Copy link
Copy Markdown
Owner

Closes #192.

What

Two lines in SKILL.md — the file an LLM reads before generating — made the generator produce scenarios the schema rejects. A wrong line there does not produce a warning, it produces invalid output repeatedly.

Shape types. ShapeType is externally tagged, but the skill described the parameterised variants as star "(with points, default 5)", which reads as a sibling field:

$ "shape": "star"
Error: invalid component — would be silently dropped at render:
       invalid type: unit variant, expected struct variant

Replaced the prose with the literal JSON for all eight variants.

motion-path. The skill still said the mechanism does not exist; #177 shipped it. Replaced with a pointer to rules/motion-path.md and a note on the near-miss it should now be preventing — motion-path in style is dropped, motion_path in animation is the effect.

Test

skill_documented_shape_spellings_parse asserts the eight documented spellings parse, and that a bare "star" stays an error — the shape the old wording implied. The skill files are embedded by build.rs, so no copy to sync.

cargo test --workspace green, cargo fmt --check and cargo clippy --all-targets -- -D warnings clean.

Two lines in SKILL.md made the generator write scenarios the schema rejects.

`ShapeType` is externally tagged, but the skill described the parameterised
variants as "star (with points, default 5)", which reads as a sibling field.
`"shape": "star"` fails with `invalid type: unit variant, expected struct
variant`; the correct spelling is `{"star": {"points": 6}}`. Show the literal
JSON for all eight variants instead of prose.

The skill also still stated that motion-path does not exist and that there is
no path-following mechanism. That stopped being true with #177. Point at
rules/motion-path.md and spell out the trap the old note should now be
preventing: `motion-path` in `style` is dropped, `motion_path` in `animation`
is the effect.

A test pins the eight documented spellings and keeps a bare `star` rejected,
so the wording cannot drift back.
@LeadcodeDev
LeadcodeDev merged commit 6dae88d into main Aug 12, 2026
3 checks passed
@LeadcodeDev
LeadcodeDev deleted the docs/skill-stale-claims branch August 12, 2026 15:25
@LeadcodeDev LeadcodeDev added the documentation Improvements or additions to documentation label Aug 12, 2026
@LeadcodeDev LeadcodeDev self-assigned this Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SKILL.md: two stale claims that make the generator write scenarios the schema rejects

1 participant