docs(skill): correct the shape spellings and the motion-path claim - #193
Merged
Conversation
Two lines in SKILL.md made the generator write scenarios the schema rejects.
`ShapeType` is externally tagged, but the skill described the parameterised
variants as "star (with points, default 5)", which reads as a sibling field.
`"shape": "star"` fails with `invalid type: unit variant, expected struct
variant`; the correct spelling is `{"star": {"points": 6}}`. Show the literal
JSON for all eight variants instead of prose.
The skill also still stated that motion-path does not exist and that there is
no path-following mechanism. That stopped being true with #177. Point at
rules/motion-path.md and spell out the trap the old note should now be
preventing: `motion-path` in `style` is dropped, `motion_path` in `animation`
is the effect.
A test pins the eight documented spellings and keeps a bare `star` rejected,
so the wording cannot drift back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #192.
What
Two lines in
SKILL.md— the file an LLM reads before generating — made the generator produce scenarios the schema rejects. A wrong line there does not produce a warning, it produces invalid output repeatedly.Shape types.
ShapeTypeis externally tagged, but the skill described the parameterised variants asstar"(withpoints, default 5)", which reads as a sibling field:Replaced the prose with the literal JSON for all eight variants.
motion-path. The skill still said the mechanism does not exist; #177 shipped it. Replaced with a pointer to
rules/motion-path.mdand a note on the near-miss it should now be preventing —motion-pathinstyleis dropped,motion_pathinanimationis the effect.Test
skill_documented_shape_spellings_parseasserts the eight documented spellings parse, and that a bare"star"stays an error — the shape the old wording implied. The skill files are embedded bybuild.rs, so no copy to sync.cargo test --workspacegreen,cargo fmt --checkandcargo clippy --all-targets -- -D warningsclean.