ci: install libasound2-dev so the studio's audio backend builds on Linux - #184
Merged
Conversation
Preview audio (#182) added rodio, which pulls cpal, which needs ALSA's development headers on Linux. The build was only ever checked on macOS, where cpal goes through CoreAudio and alsa-sys never enters the graph — so main went red on merge and every PR opened after it inherited the failure. Same line as the webkit/gtk/xdo deps already there, in both jobs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
mainhas been red since #182. Preview audio addedrodio, which pullscpal, which needs ALSA's development headers on Linux:Both the
clippyandtestjobs fail at the build step, and every PR opened since inherits the failure — #183's checks are red for this reason and not for anything in its own diff.Why it was missed
The change was verified on macOS, where
cpalgoes through CoreAudio andalsa-sysnever enters the dependency graph. Localfmt/clippy/testwere all green. Nothing in the local run could have caught it; the Linux runner is the only place this appears.How
One package added to the
apt-get installline already present in both jobs for the webkit/gtk/xdo dependencies the studio needs, with a comment saying what pulls it in.After this merges, re-running #183's checks should clear them without a rebase — its build is evaluated against the updated base.