fix(tui): dag inspector frame alignment, padding, and wave grouping - #135
Merged
Conversation
LeXwDeX
enabled auto-merge
July 29, 2026 09:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns the
/daginspector with the diff-viewer's native TUI design language, fixing three visual defects:┬/├/┴separator glyphs: the right pane never drew a left vertical border, so the horizontal separators' edge characters hung floating without a line to join. Every content block in the right pane (status row, node list, detail pane) now carriesborder={["left"]}, forming one continuous frame — same construction as the diff-viewer's patch pane.Separator start="edge-in"(┴) at the bottom of the right pane now closes the frame flush across the full width.paddingLeft/paddingRight; wave headers switch to an accent-colored label (matching which-key's section-header idiom) with a blank spacer line between waves; node names usetextwhile active and drop totextMutedonly once settled.computeNodeRowIndexcounts the new inter-wave spacer rows so scroll-into-view stays correct; its unit test updated accordingly.Test plan
tsgo --noEmitclean inpackages/tuibun test test/feature-plugins/dag-inspector*.test.*frompackages/tui), including the fixed-footer and blank-outer-row layout regressions┬/├/┴frame, full-width closing rule, spaced wave blocks