fix: preserve rotated auth tokens when switching accounts - #128
Open
serg-shcherbak wants to merge 4 commits into
Open
fix: preserve rotated auth tokens when switching accounts#128serg-shcherbak wants to merge 4 commits into
serg-shcherbak wants to merge 4 commits into
Conversation
This was referenced Aug 25, 2026
Contributor
|
I reproduced the Windows sign-in regression described in #129 and found one additional path beyond this PR: the stored ID token can be expired while the access token remains valid, so the current access-only freshness check skips refresh before switching. I opened stacked follow-up #134 on top of this branch. It preserves all commits and authorship from #128 and adds one commit that:
Local checks: 39 Rust tests passed, Clippy completed with only existing base warnings, pnpm build passed, and the Windows no-bundle release build passed. If you prefer to keep #128 as the primary PR, the follow-up commit is daac4b6 and can be cherry-picked onto this branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevents ChatGPT logout after switching from account A to B and back. ChatGPT can rotate a refresh token while an account is active; before replacing
~/.codex/auth.json, the switcher now saves the matching live token set and serializes authentication changes so a late refresh cannot restore the wrong account.Scope
This is intentionally limited to credential persistence and authentication-operation ordering. It does not add a background refresh loop, re-authentication UI, app restart behavior, localization, or a general account-store worker.
Related work
Test plan
cargo test --manifest-path src-tauri/Cargo.toml— 37 passed.pnpm build.