Fix table_info() crash on backtick-quoted table names containing dots#656
Merged
Conversation
adsharma
force-pushed
the
table_info_dot_names
branch
2 times, most recently
from
c0f0c18 to
d2fce47
Compare
When a table was created with a backtick-quoted name containing a dot
(e.g. `a.b`), CALL table_info('a.b') would split the name on '.' and
try to resolve 'a' as a database name, throwing:
Runtime exception: No database named a.
The fix: first check whether the full input string exists as a local
table name in the catalog. Only if that fails, split on '.' and try as
a database.table reference.
Added regression test (issue9.test).
adsharma
force-pushed
the
table_info_dot_names
branch
from
d2fce47 to
0c042d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: LadybugDB/explorer#35
When a table was created with a backtick-quoted name containing a dot (e.g.
a.b), CALL table_info('a.b') would split the name on '.' and try to resolve 'a' as a database name, throwing:The fix: first check whether the full input string exists as a local table name in the catalog. Only if that fails, split on '.' and try as a database.table reference.
Added regression test (issue9.test).