Use openssl-sys build-dependency instead of manual pkg-config#22
Closed
adsharma wants to merge 2 commits into
Closed
Use openssl-sys build-dependency instead of manual pkg-config#22adsharma wants to merge 2 commits into
adsharma wants to merge 2 commits into
Conversation
…nSSL linking Commit b624435 replaced the bundled third-party library linking with a self-contained liblbug archive, but left a fragile pkg-config invocation to find OpenSSL. The openssl-sys crate is the standard Rust approach: - Uses pkg-config correctly across platforms (macOS, Linux, Windows) - Supports OPENSSL_DIR, OPENSSL_LIB_DIR, OPENSSL_INCLUDE_DIR env vars - Supports vendored OpenSSL via the 'vendored' feature (openssl-src) - Handles OpenSSL 3.x naming and discovery automatically - Well-maintained, widely used ecosystem crate Removed the manual Command::new("pkg-config") + hardcoded rustc-link-lib directives in favor of openssl-sys as a build-dependency.
adsharma
force-pushed
the
fix-openssl-via-openssl-sys
branch
from
ab06682 to
137eef1
Compare
Contributor
Author
|
This approach isn't working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #20
Commit b624435 replaced the bundled third-party library linking with a
self-contained liblbug archive, but left a fragile pkg-config invocation
to find OpenSSL. The openssl-sys crate is the standard Rust approach:
Removed the manual Command::new("pkg-config") + hardcoded
rustc-link-lib directives in favor of openssl-sys as a build-dependency.