pg_client: rename fkrel_ prefix to rel_, reserve csr_rel_ for CSR-backed rels - #65
Open
adsharma wants to merge 2 commits into
Open
pg_client: rename fkrel_ prefix to rel_, reserve csr_rel_ for CSR-backed rels#65adsharma wants to merge 2 commits into
adsharma wants to merge 2 commits into
Conversation
When table name starts with rel_, query foreign keys from the db to determine src/dst node tables and create a RelGroupCatalogEntry instead of a NodeTableCatalogEntry.
…ked rels Align the pg_client naming convention with the cross-extension convention documented in docs/foreign_rel_table.md: - rel_*: foreign-key-backed, scan-driven relationship tables (RelGroupCatalogEntry + ForeignRelTable) - csr_rel_*: reserved for attach-time materialization into a local on-disk CSR RelTable; not implemented yet, currently routed through the same scan-driven path as rel_* The two prefixes are disjoint (csr_rel_x does not match the "rel_" prefix), so the branch order in init() is immaterial. Test fixtures, expected outputs and case names updated accordingly.
adsharma
added a commit
that referenced
this pull request
Aug 27, 2026
Match the pg_client naming convention (PR #65): rel_* = foreign-key-backed, scan-driven relationship tables; csr_rel_* is reserved for attach-time materialization into a local on-disk CSR RelTable and currently routes through the same scan-driven path until COPY-based materialization lands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the pg_client table-name convention with the cross-extension naming convention:
node_*rel_*RelGroupCatalogEntry+ForeignRelTable)csr_rel_*RelTable(not implemented yet; routed through the same scan-driven path asrel_*)init()now dispatches onrel_(FK-backed) andcsr_rel_(CSR intent). The prefixes are disjoint, so branch order is immaterial.test_pg_client.py,pg_client.test,create_pg_client_test_db.sql) renamed:fkrel_knows→rel_knows,fkrel_works_at→rel_works_at; case namesScanFkRelTable→ScanRelTable,MatchOnFkRelTable→MatchOnRelTable;SHOW_TABLESexpectations updated.Tests run in CI.