Skip to content

Bump icebug 13.2.0 -> 13.5.0 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adsharma merged 1 commit into from
Oct 25, 2026
Merged

Bump icebug 13.2.0 -> 13.5.0 #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ icebug-analytics = ["dep:icebug"]
[dependencies]
gpui = "0.2"
lbug = { version = "0.22.0", features = ["arrow"] }
icebug = { version = "=13.2.0", optional = true }
icebug = { version = "=13.5.0", optional = true }
# Pinned to 55 to match lbug's `arrow` (0.21.x/0.22.x use arrow 55): lbug hands us
# Arrow batches built with its own arrow, so our decode types must be the
# same crate version or every `downcast_ref` silently yields nothing.
Expand All @@ -19,7 +19,7 @@ arrow-flight = "55"
tonic = { version = "0.12", features = ["transport"] }
tokio = { version = "1", features = ["full"] }
futures = "0.3"
# icebug 13.2.0 instead needs arrow 56 (`arrow-array`/`arrow-buffer` 56.x),
# icebug 13.5.0 instead needs arrow 56 (`arrow-array`/`arrow-buffer` 56.x),
# so the in-process analytics arrays use this alias.
arrow56 = { package = "arrow", version = "56", default-features = false, features = ["ffi"] }
serde = { version = "1", features = ["derive"] }
Expand Down
2 changes: 1 addition & 1 deletion scripts/install-arrow25-macos.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env bash
# Install Apache Arrow 25 on macOS CI from a pinned Homebrew formula.
#
# The icebug prebuilt (scripts/download_icebug.sh, ICEBUG_VERSION 13.2)
# The icebug prebuilt (scripts/download_icebug.sh, ICEBUG_VERSION 13.5)
# links `@rpath`-style `libarrow.2500.dylib` (Arrow 25.x), but Homebrew core
# only ever carries the latest release (26.x as of Oct 2026) and has no
# versioned `apache-arrow@25` formula. Installing latest would give
Expand Down
4 changes: 2 additions & 2 deletions src/backend.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ pub fn ensure_algo_extension(conn: &Connection) -> bool {
/// an empty ranking (callers show an empty Top PageRank list).
#[cfg(feature = "icebug-analytics")]
pub fn graphr_page_rank(data: &GraphData) -> Vec<(String, f64)> {
// icebug 13.2.0 speaks arrow 56: build with the alias, not the
// icebug 13.5.0 speaks arrow 56: build with the alias, not the
// lbug-pinned `arrow` (55).
use arrow56::array::UInt64Array;
let index: HashMap<&str, u64> = data
Expand Down Expand Up @@ -1996,7 +1996,7 @@ pub fn graphr_page_rank(data: &GraphData) -> Vec<(String, f64)> {
/// equality matters.
#[cfg(feature = "icebug-analytics")]
pub fn graphr_leiden_full(data: &GraphData) -> (Vec<u64>, f64, u64) {
// icebug 13.2.0 speaks arrow 56: build with the alias, not the
// icebug 13.5.0 speaks arrow 56: build with the alias, not the
// lbug-pinned `arrow` (55).
use arrow56::array::UInt64Array;
let n = data.nodes.len();
Expand Down
Loading