Skip to content

Fix issue 812#989

Merged
ogazboiz merged 6 commits into
LabsCrypt:mainfrom
TheShnider:fix-issue-812
Jul 4, 2026
Merged

Fix issue 812#989
ogazboiz merged 6 commits into
LabsCrypt:mainfrom
TheShnider:fix-issue-812

Conversation

@TheShnider

Copy link
Copy Markdown
Contributor

Description

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔧 Refactoring (no functional changes)
  • ⚡ Performance improvement
  • 🧪 Test addition or update

Related Issues

Closes #812

Changes Made

Testing

Test Coverage

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed

Test Steps

Breaking Changes

Breaking Changes:

Migration Guide:

Screenshots/Demo

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published
  • I have checked for breaking changes and documented them if applicable

Additional Notes

@ogazboiz ogazboiz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct guard for issue 812, top-up now returns 409 when the stream is inactive or paused (you shouldn't be able to add funds to a stopped stream), with tests covering both cases. merging. (tiny nit: there's a double blank line after the guards, harmless.)

@ogazboiz ogazboiz merged commit 9de5b01 into LabsCrypt:main Jul 4, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Backend] POST /v1/streams/:streamId/top-up does not reject cancelled/inactive or paused streams

2 participants