Fix/jwt signature verification#986
Open
Benedict315 wants to merge 11 commits into
Open
Conversation
ogazboiz
requested changes
Jul 4, 2026
ogazboiz
left a comment
Contributor
There was a problem hiding this comment.
this is security-sensitive so i looked closely, and it can't land as-is:
- there are unresolved git merge-conflict markers committed into backend/src/middleware/auth.ts (~lines 118-135), which fails tsc everywhere.
- more seriously, the "ours" side of that conflict is an auth-bypass: it references vars that don't exist (providedSig/expected instead of the actual ...Buf names), and crypto.timingSafeEqual throws on a length mismatch into a catch that does NOT return null, so a token with a wrong-length signature gets ACCEPTED. that's a real vulnerability.
please resolve the conflict by keeping themainside (which length-checks before timingSafeEqual and returns null correctly) and drop this pr's comparison logic. the intent (hardening verifyJwt) is right, the implementation just must not weaken it. also note this near-duplicates your #985, keep the a11y in #985 and just the (corrected) jwt work here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Related Issues
Closes #
Changes Made
Testing
Test Coverage
Test Steps
Breaking Changes
Breaking Changes:
Migration Guide:
Screenshots/Demo
Checklist
Additional Notes
closes #632