Skip to content

Feat/playwright e2e ci 343 rebase#727

Open
Francis6-git wants to merge 8 commits into
LabsCrypt:mainfrom
Francis6-git:feat/playwright-e2e-ci-343-rebase
Open

Feat/playwright e2e ci 343 rebase#727
Francis6-git wants to merge 8 commits into
LabsCrypt:mainfrom
Francis6-git:feat/playwright-e2e-ci-343-rebase

Conversation

@Francis6-git

Copy link
Copy Markdown
Contributor

Re-enabling the Playwright end-to-end integration flow from closed PR #343.

This branch handles E2E stream lifecycles without local state bloat. It sets up an isolated environment pipeline via GitHub Actions using matrix configuration structures optimized directly alongside recent updates to main. Local execution test results and raw HTML reports have been explicitly stripped from tracking trees and isolated inside .gitignore.

@ogazboiz

ogazboiz commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

hey, main has moved significantly today (10+ PRs merged including the JWT test fix and various backend fixes). your branch's CI failure is on a stale base. please rebase:

git fetch upstream
git rebase upstream/main
git push --force-with-lease

main is green right now, so CI should clear on the rebased commit.

@ogazboiz

ogazboiz commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

heads up: main's ci was broken (the Backend CI and Backend Docker Image CI jobs) until the fixes in #969 and #974 just landed, so the red backend/docker checks on this pr are almost certainly stale, they ran against the broken main. please rebase to re-test against the now-green main: git fetch origin && git rebase origin/main && git push --force-with-lease. once it's green i'll review and merge. (if a non-backend check like Frontend CI is still red after the rebase, that part is a real issue worth a look, since frontend ci was passing on main.)

@Francis6-git

Copy link
Copy Markdown
Contributor Author

Thank you @ogazboiz for bringing it up, I've already forgotten that I made this PR to be honest.

@Francis6-git Francis6-git force-pushed the feat/playwright-e2e-ci-343-rebase branch from a2e1ff4 to 7033d1d Compare July 1, 2026 11:05
@Francis6-git Francis6-git force-pushed the feat/playwright-e2e-ci-343-rebase branch from 7033d1d to 7170903 Compare July 1, 2026 11:23

@ogazboiz ogazboiz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this, the playwright e2e setup is genuinely useful and it's green across the board now. good stuff in here: the new e2e job (needs: frontend, playwright browser cache, build then npx playwright test) is structured well, the stream-lifecycle spec is real coverage, the dashboard-view redirect fix (/app/streams/ -> /streams/) is a legit bug fix, and the E2E_MOCK_SOROBAN window seam is a reasonable way to mock soroban from the tests. also heads up the +9269 looks scary but ~8700 of it is just the package-lock playwright deps, so that part's expected.

one real thing to fix before it can land, plus two minor notes:

  1. (blocker) the pr commits test-run artifacts into the repo: test-results/.last-run.json and test-results/frontend-e2e-...-resume-and-cancel-a-stream/error-context.md, and that error-context is from a FAILED run. those are transient playwright output and shouldn't be in git. please git rm -r --cached test-results/ and commit the removal. also the .gitignore you added ignores frontend/test-results/, but the committed artifacts are at the repo-root test-results/, so add test-results/ too (and keep playwright's outputDir consistent) so it can't happen again.

  2. minor: logger.ts drops the // eslint-disable-line no-console comments while keeping the console.* calls. it's passing now, but if the no-console rule is still on that could re-flag later, worth confirming that's intentional.

  3. minor: the soroban.ts E2E_MOCK_SOROBAN checks use (window as any) with 6 eslint-disable-next-line lines. fine for a test seam, but a small typed declaration (e.g. interface Window { E2E_MOCK_SOROBAN?: boolean }) would drop all six any-casts.

remove the committed test-results and fix the gitignore path and this is good to merge, the e2e work itself is solid.

@Francis6-git

Copy link
Copy Markdown
Contributor Author

Requested changes has been made @ogazboiz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants