Repository navigation
fix: Resolve 4 remaining dogfood issues - #10
Merged
Merged
Conversation
… Docker
Phase 1: Add ListResponse[T] wrapper to 6 list endpoints (audiences,
api-keys, webhooks, topics, contact properties, segments) so frontend
`data?.data ?? []` pattern works correctly.
Phase 2: Fix broadcast field names (total_recipients→recipients,
sent_count→sent, add audience_name). Fix domain dns_records field name
and wrap GET /domains/{id} in {data: ...}.
Phase 3: Add TemplateDetailResponse with subject, html, text, published,
updated_at. Template Get() now fetches latest version content.
Phase 4: Update Dockerfile to golang:1.25-alpine. Remove deprecated
docker-compose version field.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Expand .env.example with comprehensive documentation for all production environment variables, organized by service with clear descriptions - Improve setup.sh with robust validation, better error handling, and support for both 'docker compose' and legacy 'docker-compose' command - Enhance generate-dkim.sh with validation, file permission handling, and clearer DNS record instructions - Update docker-compose.yml with full configuration documentation, container names, enhanced healthchecks, and network isolation - Expand README deployment section with step-by-step Docker Compose setup, manual configuration steps, production recommendations, DNS setup guide, and Kubernetes/Helm examples All improvements maintain backward compatibility while making deployment and initial setup significantly clearer and more robust. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Broadcast audience_name: LEFT JOIN audiences in list query, populate
AudienceName in response DTO
- Domain detail: remove redundant {"data": resp} wrapper from GET
/domains/{id}, align frontend to read bare response
- Metrics: relax hasData condition to show charts when data points exist
even if totals.sent is 0
- Template versions: add version_count subquery to list query, surface
Versions field in TemplateResponse DTO
- Gitignore: add .agent/, .agents/, skills-lock.json, dogfood-output/
LLRHook
added a commit
that referenced
this pull request
Mar 8, 2026
- Add page test for audience dashboard - 3 test cases: header, description, all four tab triggers - Mark task #10 done in quality plan (103 tests total)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{"data": resp}wrapper fromGET /domains/{id}— now returns bare object consistent with other single-item endpoints. Frontend updated to match.hasDatacondition — charts now render when data points exist even iftotals.sentis 0versionscount in the DTOAlso adds
.agent/,.agents/,skills-lock.json, anddogfood-output/to.gitignore.Test plan
go build ./...— cleango vet ./...— cleango test ./...— 314 tests passnext build— cleanvitest run— 55 tests pass