Add FXMacroData release-calendar integration - #90
Open
roberttidball wants to merge 3 commits into
Open
Conversation
keli-wen
added
type: feature
Switches the base URL from the undocumented fxmacrodata.com/api/v1 alias to the published api.fxmacrodata.com/v1 host, so the client matches the public API reference.
The fetch layer documents that every function is async and returns a frozen dataclass, leaving interpretation to the format layer. This fetcher returned the raw JSON dict instead, so it did not satisfy that contract. It now returns a frozen RawCalendar holding frozen CalendarRelease rows, matching how fetch_rss_feed returns RawFeed and FeedItem. The response envelope (currency, timezone, data quality) is preserved as metadata so the format layer does not need a second request. Row fields now match the documented calendar response: release, name, announcement_datetime_utc, announcement_datetime_local, release_date_confirmed, event_importance, market_tier, source and source_url. The API key is sent as the X-API-Key header rather than a query parameter, so it is not captured in request or proxy access logs.
roberttidball
force-pushed
the
agent/add-fxmacrodata-integration-20260708
branch
from
August 26, 2026 02:35
546637d to
ee69ce8
Compare
roberttidball
marked this pull request as ready for review
August 26, 2026 02:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://fxmacrodata.com/api/v1/calendar/{currency}endpoint with optionalFXMACRODATA_API_KEYValidation
git diff --checkpython -m py_compileon changed.pyfiles where applicableNote: R is not installed in this local environment, so R package changes were reviewed but not executed with
R CMD check.