fix: embed compose files, fix PostgreSQL refs, align Go module path#46
Merged
Conversation
mohit-nagaraj
requested review from
Kshitijknk07,
Naman-B-Parlecha and
rishichirchi
as code owners
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
4 tasks
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request renames the project organization from kubeorchestra to kubeorch, updates the database from PostgreSQL to MongoDB, and introduces embedded Docker Compose configurations for various development and production environments. Key feedback includes updating image registry paths in the new Compose files to reflect the organization change, ensuring consistent environment variable naming for the UI service, and addressing hardcoded container names in the exec command that currently prevent it from working correctly in development or hybrid modes.
mohit-nagaraj
force-pushed
the
fix/embed-compose-and-bugs
branch
4 times, most recently
from
08665e8 to
2ad0bcb
Compare
…urity - Embed all docker-compose files into binary via go:embed so orchcli init writes them to docker/ — fixes broken init+start flow - Fix Go module path: github.com/kubeorchestra/cli → github.com/kubeorch/cli to match GitHub org; fixes version injection via ldflags in releases - Replace all PostgreSQL references with MongoDB (waitForMongoDB, exec service map, next-steps output) - Auto-generate core/config.yaml (with random secrets) and ui/.env.local during orchcli init based on dev mode - Fix Docker image names: ghcr.io/kubeorchestra/* → ghcr.io/kubeorch/* - Fix exec.go to use actual running container name (resolves -dev/-hybrid suffix issue in dev and hybrid modes) - Fix API_URL_INTERNAL consistency across all compose files - Fix lint: replace magic numbers with named constants (dirPerm, configFilePerm, composeFilePerm, secretKeyBytes) - Fix gosec G306: add #nosec annotations for compose/env files (0644 is intentional — these files contain no secrets) - Fix Windows CI: add shell: bash to steps using bash syntax Fixes #45 Signed-off-by: Mohit Nagaraj <mohitnagaraj20@gmail.com>
mohit-nagaraj
force-pushed
the
fix/embed-compose-and-bugs
branch
from
2ad0bcb to
efcfd03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go:embedsoorchcli initwrites them todocker/— fixes the brokenorchcli init+orchcli startflowwaitForMongoDB, exec service map, next-steps output) to match actual compose filesgithub.com/kubeorchestra/clitogithub.com/kubeorch/clito match the GitHub org and fix version injection via ldflags in the release workflowTest plan
go buildcompiles successfullyorchcli initcreates compose files indocker/orchcli start -dstarts services without "compose file not found" errororchcli statusshows MongoDB health, not PostgreSQLorchcli exec mongodbopens mongoshorchcli --versionshows actual version instead ofdevFixes #45
Related: KubeOrch/docs#14