[#477] Remove obsolete hacker class logic from check-in#478
Conversation
Co-authored-by: Codex <codex@openai.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (12)
📝 WalkthroughWalkthroughRemoves the Knight Hacks VIII hacker class assignment system from check-in. Deletes ChangesHacker class removal and BloomKnights migration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Why
Hacker check-in was still coupled to the completed Knight Hacks VIII class system. That behavior assigned and balanced classes, applied class-specific admission rules, rendered class controls and results, and granted hardcoded KH8 Discord roles even though upcoming BloomKnights check-in is classless.
This PR makes hacker check-in classless and limits event-role assignment to BloomKnights while leaving the legacy nullable database column untouched for a future database-configurable system.
What
Closes: #477
checkedinforCheck-inevents.15107510657866834121520492619921227836HackerAttendee.classas an inert nullable legacy column; no migration was generated.hackathonIdandeventPointsfields for this scoped change.No environment variables, dependencies, migrations, or deployment configuration were changed.
Test Plan
Completed locally:
pnpm formatpnpm lintpnpm typecheckgit diff --checkStill to verify against an integrated event/Discord environment:
Check-inevent and verify status, attendance, points, and the development Discord role.classcolumn remains null.Check-inevent eligibility.Screenshots were not captured; the UI change removes the obsolete class selector/result and updates the success guidance.
Checklist
pnpm db:generateand committed the generated files inpackages/db/drizzle/Summary by CodeRabbit