Repository navigation
i18n: add Vietnamese translation - #1068
Merged
Merged
Conversation
KnifeLemon
approved these changes
Nov 3, 2026
KnifeLemon
left a comment
Owner
There was a problem hiding this comment.
Thank you, @dinhkarate! Vietnamese is added the same way as Italian and Indonesian:
vi.jsonwith all 1,421 keys, inen.json's order;AppLanguagesand the auto-selection (vi/vi-*, notvin);- the macOS
vi.lprojfiles andCFBundleLocalizations; - Setup's
/LANGlist and the tests.
I merged current main locally: vi.json still matches it key for key, and the localization and render tests pass (368). I also looked at the rendered pages: the diacritics come out right, and the labels fit the sidebar, the toolbar editor and the palette.
I'll merge once CI is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tip
Start the title with a prefix so the PR is labeled automatically:
feat:fix:docs:ci:build:i18n:What does this change?
Adds Vietnamese (Tiếng Việt) as a UI language. It is registered the same way Italian (#732) and Indonesian were added:
src/Filee.App/Assets/i18n/vi.json(all 1421 keys, same order asen.json)AppLanguagesentry("vi", "Tiếng Việt")and auto-selection inLocalizationService(matchesvi/vi-*but not Vinzavin)vi.lproj/InfoPlist.strings,vi.lproj/ServicesMenu.strings,viinCFBundleLocalizations/LANGlist comment inSetupOptions.csvi-VN,vi,vin-TZ), the chosen-language row,Vietnamese_is_offered_under_its_own_name, Setup text rows, and thevirender pages inRenderTestsType of change
How was it tested?
dotnet format --verify-no-changesdotnet testChecks I ran:
vi.jsonparses, has no duplicate keys or empty values, and has the same keys in the same order asen.json{0}-style placeholders and line breaks as English, with no literal\ndonut.flip_to_backanddonut.flip_to_frontstart with{0}plutil -lintpasses onInfo.plistand on bothvi.lproj.stringsfilesScreenshots (UI changes)
Checklist
src/Filee.App/Assets/i18n/*.jsonfilesTHIRD-PARTY-NOTICES.md(none added)