Upgrade Vuetify to 3.12.10, Adjust Directory Structure#39
Open
snacksbro wants to merge 5 commits into
Open
Conversation
Since the file hosted on jsdeliver points to default v4 docs
snacksbro
commented
Jul 17, 2026
snacksbro
commented
Jul 17, 2026
Author
There was a problem hiding this comment.
I did notice that uv.lock was never tracked so I ignored both the uv lock and the npm lock in my local environment, hence why this occurred post-migration. Should uv.lock be tracked?
Collaborator
There was a problem hiding this comment.
uv.lock does not need to be tracked. At least not here for building that lib.
snacksbro
marked this pull request as ready for review
July 17, 2026 12:14
jourdain
reviewed
Jul 17, 2026
| @@ -1,5 +1,5 @@ | |||
| const path = require('path'); | |||
| const DST_PATH = '../trame_vuetify/module/vue2-serve'; | |||
| const DST_PATH = '../trame_vuetify/module/v2-serve'; | |||
Collaborator
There was a problem hiding this comment.
Don't we have more ../.. to go up now that we added a js-libs hierarchy?
jourdain
reviewed
Jul 17, 2026
jourdain
reviewed
Jul 17, 2026
| def get_docs(tag): | ||
| url = tag.get("doc-url", "https://vuetifyjs.com/en/introduction/why-vuetify/") | ||
| url = url.replace("www.", "") # www redirects to start page | ||
| url = url.replace("vuetifyjs", "v3.vuetifyjs") # the hosted file points to v4 docs |
Collaborator
There was a problem hiding this comment.
You may want to be more specific like /vuetifyjs to /v3.vuetifyjs
jourdain
requested changes
Jul 17, 2026
jourdain
left a comment
Collaborator
There was a problem hiding this comment.
It seems the vue2 vue.config.js needs a fix. Everything else seems fine to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates Vuetify 3 from 3.11.2 -> 3.12.10.
This also makes the generated Python code use the v3 documentation, I noticed the types URL at https://cdn.jsdelivr.net/npm/vuetify@3.12.10/dist/json/web-types.json would have the
doc-urlfield point to https://vuetifyjs.com/api/VAlert#props rather than https://v3.vuetifyjs.com/api/VAlert#props. This is simply a find/replace in thegenerate_python.pyscript to prependv3to the URL.Lastly, this also restructures the folder structure in preparation for the arrival of Vuetify 4. This is the part I have the least confidence of me doing correctly, I believe I updated everything but I haven't tested the release workflow. These changes are all in 1f9148e
I verified this worked by installing my fork of Trame Vuetify into an existing Trame Project and using a component introduced in v3.12.x, a minimal example can be seen here:
Minimal Example