Limit desktop library select-all to the current page - #1916
Open
mattdawkins wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desktop library's header checkbox selected every matching dataset across multiple pages. It now checks or unchecks only the rows displayed on the current page after sorting and filtering, and its checked/indeterminate state reflects those rows. Existing selections on other pages are preserved.
Add 1000 and All after the existing 20, 50, and 100 page-size options in the desktop library. All displays every dataset matching the current search, allowing the header checkbox to select all displayed matches intentionally.
Validation: ESLint for Recent.vue and full client type checking passed. Existing desktop frontend query tests passed (5 tests).