Ignore nonpositive detection lengths when importing VIAME CSV - #1915
Open
mattdawkins wants to merge 1 commit into
Open
Ignore nonpositive detection lengths when importing VIAME CSV#1915mattdawkins wants to merge 1 commit into
mattdawkins wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VIAME CSV imports could create zero or negative detection length attributes. Ignore nonpositive lengths from the dedicated length column and explicit
(atr) lengthfields in the desktop and Python importers. Positive attribute lengths retain precedence, with a positive column length used as fallback, and unrelated attributes are preserved.Added 20 regression cases per importer covering absent, zero, negative, and positive attribute lengths against zero, negative, and positive column lengths, including generated attribute definitions.
Validation: 48 Python CSV import/export tests and 34 desktop CSV tests passed; ESLint on both changed TypeScript files and Black checks on both changed Python files passed.