Fix stale annotation indices and redraw watchers after reload - #1914
Open
mattdawkins wants to merge 1 commit into
Open
Fix stale annotation indices and redraw watchers after reload#1914mattdawkins wants to merge 1 commit into
mattdawkins wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reloading pipeline annotations could leave stale detections in the frame index and redraw watchers attached to a destroyed viewer. Clear the interval tree directly when replacing annotations, and mount the tooltip after LayerManager setup so its redraw watchers are disposed with the component.
Regression tests cover clearing and repopulating the frame index, stopping redraws after the old viewer unmounts, and updating the replacement viewer once.
Validation:
git diff --checkpassed.