e2e runs retry downloads and are headless#885
Merged
Conversation
Flaky connectivity to data.kitware.com could fail a single onPrepare download, leaving .tmp without the dataset and causing specs to fail at the render-wait step as if WebGL were broken. Retry each download up to 3 times, write atomically via a .part rename so a partial download is never cached as complete, and check response.ok so an error page is not saved as DICOM.
Local wdio launched headed chrome on the WSLg desktop, so browser windows popped up on the host display during every test run. Default to headless (with --enable-unsafe-swiftshader, since chrome no longer auto-falls back to software WebGL) and add a HEADED=1 escape hatch for watching tests. CI behavior is unchanged.
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small fixes to the wdio e2e setup.
e2e runs retry downloads and are headless