Add typed modeling connection errors - #1340
Draft
pierremtb wants to merge 3 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1340 +/- ##
=======================================
Coverage ? 36.66%
=======================================
Files ? 37
Lines ? 1923
Branches ? 0
=======================================
Hits ? 705
Misses ? 1218
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pierremtb
force-pushed
the
pierremtb/modeling-terminal-connection-errors
branch
from
August 26, 2026 10:05
2d5a2b2 to
a20b74d
Compare
pierremtb
marked this pull request as draft
September 3, 2026 13:39
pierremtb
force-pushed
the
pierremtb/modeling-terminal-connection-errors
branch
from
September 7, 2026 14:45
a20b74d to
d51152b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ModelingWebSocketResponseenvelope while leaving the legacyWebSocketResponseunchangedEngineParams.kcl_versionrepresented as a string in JSON Schema so API OpenAPI generation remains compatiblekittycad-modeling-cmds0.2.232; 0.2.231 was already reserved when this branch was rebasedStack
Consumed by KittyCAD/api#4472.