Skip to content

Add helix entity references - #1319

Open
Irev-Dev wants to merge 3 commits into
mainfrom
kurt-curve3d-entity-reference
Open

Add helix entity references#1319
Irev-Dev wants to merge 3 commits into
mainfrom
kurt-curve3d-entity-reference

Conversation

@Irev-Dev

@Irev-Dev Irev-Dev commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

We noticed that selecting a standalone helix through the face API returned an empty entity-reference payload, so the app had no stable way to identify or reuse the selected object in point-and-click commands.

This adds a narrow Helix { helix_id } entity-reference variant carrying the helix object's existing UUID. We originally modeled this as a generic 3D curve, but that exposed a broader protocol concept than we currently support; keeping the schema helix-specific fixes the concrete gap without making assumptions about future 3D curve entities.

Engine PR: https://github.com/KittyCAD/engine/pull/4882

@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@da54cc1). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1319   +/-   ##
=======================================
  Coverage        ?   35.73%           
=======================================
  Files           ?       37           
  Lines           ?     1858           
  Branches        ?        0           
=======================================
  Hits            ?      664           
  Misses          ?     1194           
  Partials        ?        0           
Flag Coverage Δ
unittests 35.73% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Irev-Dev
Irev-Dev marked this pull request as ready for review August 6, 2026 04:14
@Irev-Dev Irev-Dev changed the title Add standalone 3D curve entity references Add helix entity references Aug 6, 2026
@Irev-Dev
Irev-Dev force-pushed the kurt-curve3d-entity-reference branch from 950ed7c to 3200394 Compare August 7, 2026 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants