Retry transient websocket auth failures - #246
Draft
ksbharaj wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
CI note: the exact new test The full live-engine job was retried twice after the initial run. Each attempt
These failures are outside the changed retry helper and are non-deterministic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zoo-kclexecutionWhy
The native
zoo-kclclient supplies its bearer token on every WebSocket HTTPupgrade. In traces
01a045fc-64b2-7a9f-868f-81c9caf0301band01a04620-05b2-7f7c-8fc1-7533ecf8697d, the API intermittently returned:Other engine calls in the same traces succeeded with the same process
credentials.
zoo-kclcurrently reports this response as non-retryable, soMCP's existing execution retry loop does not recover. This PR recognizes only
that distinctive server instruction and opens a fresh authenticated socket.
Validation
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 .venv/bin/pytest -p asyncio tests/test_server.py -k 'execute_with_retries' -vv(6 passed).venv/bin/ruff check --fix ..venv/bin/ruff format ..venv/bin/ruff format --check --diff.venv/bin/ty check .