Skip to content

refactor: make scalar expressions arena-backed - #380

Merged
KKould merged 2 commits into
mainfrom
refactor/arena-backed-scalar-expressions
Sep 3, 2026
Merged

refactor: make scalar expressions arena-backed#380
KKould merged 2 commits into
mainfrom
refactor/arena-backed-scalar-expressions

fix: preserve arena expression ownership boundaries

113fb7d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 2, 2026 in 0s

93.07% (+0.11%) compared to 8028dc6

View this Pull Request on Codecov

93.07% (+0.11%) compared to 8028dc6

Details

Codecov Report

❌ Patch coverage is 95.03841% with 239 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.07%. Comparing base (8028dc6) to head (113fb7d).

Files with missing lines Patch % Lines
src/orm/mod.rs 81.73% 57 Missing ⚠️
src/expression/mod.rs 90.45% 36 Missing ⚠️
src/expression/simplify.rs 84.65% 29 Missing ⚠️
src/optimizer/rule/normalization/column_pruning.rs 71.66% 17 Missing ⚠️
src/expression/range_detacher.rs 97.05% 14 Missing ⚠️
src/expression/eq_col.rs 98.37% 13 Missing ⚠️
src/planner/arena.rs 89.88% 9 Missing ⚠️
src/expression/visitor_mut.rs 95.97% 8 Missing ⚠️
...ptimizer/rule/normalization/pushdown_predicates.rs 93.63% 7 Missing ⚠️
src/expression/visitor.rs 96.27% 6 Missing ⚠️
... and 22 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #380      +/-   ##
==========================================
+ Coverage   92.95%   93.07%   +0.11%     
==========================================
  Files         255      257       +2     
  Lines       43770    45289    +1519     
==========================================
+ Hits        40687    42152    +1465     
- Misses       3083     3137      +54     
Files with missing lines Coverage Δ
src/binder/analyze.rs 96.00% <100.00%> (ø)
src/binder/copy.rs 71.73% <100.00%> (ø)
src/binder/create_view.rs 100.00% <100.00%> (ø)
src/binder/expr.rs 94.17% <100.00%> (-0.09%) ⬇️
src/binder/update.rs 100.00% <100.00%> (ø)
src/catalog/column.rs 92.45% <100.00%> (-3.26%) ⬇️
src/catalog/table.rs 98.76% <100.00%> (+<0.01%) ⬆️
src/db.rs 91.97% <100.00%> (-1.00%) ⬇️
src/execution/ddl/add_column.rs 97.11% <100.00%> (ø)
src/execution/ddl/create_index.rs 92.39% <100.00%> (ø)
... and 98 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.