Update additional PSP VFPU instructions - #257
Open
tclamb wants to merge 1 commit into
Open
Conversation
* fixed transposed matrix row/column register encoding * removed invalid instructions `vwbn.p/t/q` * fixed immediate size for `vwbn.s` * fixed `vd` size for `vsocp.s/p` (was: `vsocp.s S002,S103`, now: `vsocp.s C002,S103`) * fixed `vhtfm2.p`/`vhtfm3.t` encodings * added missing instruction `vhtfm4.q` Extracted test instructions from hrydgard/pspautotests binaries. Used MWCC to generated expected output.
tclamb
added a commit
to tclamb/ppsspp
that referenced
this pull request
Jul 23, 2026
Update armips for VFPU instruction parsing changes (Kingcom/armips#257) - fix transposed matrix register encodings (e.g. `vmidt.p E220` was assembling to `vmidt.p E202`) - fix immediate size for `vwbn.s` (is 8 bits, was limited to 5 bits) - fix `vd` register size for `vsocp.s/p` - fix `vhtfm2.p` and `vhtfm3.t` encoding - add missing instruction `vhtfm4.q` Fix `v(h)tfmX` disassembly (handle irregular vector size encoding) Fix `vsocp.s/p` disassembly (`vd` is double the size of `vs`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the PR updating PPSSPP to use the latest armips commit, @Nemoumbra pointed out a missing opcode from pspautotests. I pulled all vfpu instructions from the binaries in pspautotests for test cases.
vwbn.p/t/qvwbn.svdsize forvsocp.s/p(was:vsocp.s S002,S103, now:vsocp.s C002,S103)vhtfm2.p/vhtfm3.tencodingsvhtfm4.qUsed MWCC to generated expected output.