feat(auth): enable audience-aware readers for chat and KiloClaw - #5818
Open
pandemicsyn wants to merge 5 commits into
Open
feat(auth): enable audience-aware readers for chat and KiloClaw#5818pandemicsyn wants to merge 5 commits into
pandemicsyn wants to merge 5 commits into
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (10 files)
Previous Review Summary (commit aff7f5a)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit aff7f5a)Status: No Issues Found | Recommendation: Merge Files Reviewed (10 files)
Reviewed by grok-4.6 · Input: 91.6K · Output: 7.8K · Cached: 380.7K Review guidance: REVIEW.md from base branch |
Base automatically changed from
feat/worker-audience-readers-batch-1
to
main
September 1, 2026 19:59
iscekic
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 4, batch 2: enable resource-audience validation for Kilo Chat, Event Service, Notifications, and the active KiloClaw JWT readers. Each accepts correctly addressed tokens or supported audience-less legacy tokens, and rejects explicit mismatches or malformed audiences.
Stacked on #5815 to reuse its opt-in shared verifier. This PR contains one batch-two commit; retarget to
mainafter batch one merges.Verification
No manual browser or deployed-service testing was performed. This is a reader-only backend change; real signed-token and middleware behavior was exercised through automated suites using local Worker runtimes and mocked dependencies rather than production credentials. Automated results are listed below.
Visual Changes
N/A
Reviewer Notes
Automated validation on the final stacked base:
git diff --checkpassed.