feat(cloud-agent-next): add durable control-plane diagnostics - #5805
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryIncremental review of the Workers test-pool pin ( Files Reviewed (2 files)
Previous Review Summaries (5 snapshots, latest commit 129e53c)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 129e53c)Status: No Issues Found | Recommendation: Merge Executive SummaryIncremental review of archive-read endpoint removal in five files found no high-confidence bugs; upload-only log routes and R2-direct retrieval docs remain consistent. Files Reviewed (5 files)
Previous review (commit 2ed6865)Status: No Issues Found | Recommendation: Merge Executive SummaryIncremental review of diagnostic-volume reduction (heartbeat peak counters and suppressed successful Files Reviewed (4 files)
Previous review (commit 97f0e1a)Status: No Issues Found | Recommendation: Merge Executive SummaryIncremental review of accepted-runtime reconciliation diagnostics in four files found no high-confidence bugs; existing sync/fail-delivery behavior is preserved. Files Reviewed (4 files)
Previous review (commit 3e42b05)Status: No Issues Found | Recommendation: Merge Files Reviewed (32 files)
Previous review (commit 60ee4a3)Status: No Issues Found | Recommendation: Merge Files Reviewed (25 files)
Reviewed by grok-4.6 · Input: 95.3K · Output: 4.1K · Cached: 123.6K Review guidance: REVIEW.md from base branch |
60ee4a3 to
f820790
Compare
f820790 to
3e42b05
Compare
Pin this service to vitest-pool-workers 0.18.6 for cloudflare/workers-sdk#14678, which fixes console forwarding from a broken Durable Object input gate.
Summary
Verification
No manual/live-provider end-to-end validation or deployment was performed. Live-provider verification remains outstanding; automated coverage is listed below.
Visual Changes
N/A
Reviewer Notes
Based on main at
9398fade1, with three focused commits covering core diagnostics, worktree lifecycle, and accepted-runtime reconciliation. The logging follow-ups use existing behavioral tests; no diagnostic-only tests were added.Automated checks passed on the final changes:
git diff --check.pnpm exec vitest run src/sandbox-session src/sandbox-control/log-routes.test.ts— 331 passed.bun test src/control— 373 passed;bun test src/kilo-api.test.ts— 82 passed.An initial combined wrapper run hit the known 500ms child-startup fixture flake; the fixture and both suites passed separately. A parallel filtered Workers run hit a console-reporter teardown error; serial reconnect/full-deletion suites passed. No test workaround was added.
A complete Workers control-suite run remains unverified: earlier runs timed out during teardown after printing test passes. The focused runtime suites above pass, but this is not full integration or live-provider coverage. No runner workaround was added.
Verbose metadata logging is enabled by default. Upload grants expire after four hours without renewal. R2 retention remains governed by the existing external bucket policy; this PR does not change retention or add historical-data processing.