Skip to content

feat(mobile): deliver glanceable snapshot updates - #5620

Open
iscekic wants to merge 42 commits into
audit-w8b-live-activities-3cf8-s3from
audit-w8b-live-activities-3cf8-s4
Open

feat(mobile): deliver glanceable snapshot updates#5620
iscekic wants to merge 42 commits into
audit-w8b-live-activities-3cf8-s3from
audit-w8b-live-activities-3cf8-s4

Conversation

@iscekic

@iscekic iscekic commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Summary

The iOS app now keeps the Active Agents Live Activity and the Lock Screen and Home Screen widgets current while the app is backgrounded or closed. They show how many agents are running, need input, or are reconnecting, a status line such as "No work in progress", and how long eligible work has run.

The Android Active Agents notification now updates in the background instead of only while the app is open.

If the device cannot show Live Activities, the Agents tab shows a one-time prompt to open Settings and enable them.

Signing out now also removes the device's background-update registration, so the signed-out account stops updating the Live Activity and widgets.


Reviewer Notes

A user_activity_tokens table stores device activity tokens for the glanceable surfaces. It holds the iOS push-to-start, iOS activity, and Android ongoing tokens, keyed by user and an optional organization, with a unique constraint on the token and cascade deletion with the user. Account soft-delete now also deletes these rows so a deleted user stops receiving glanceable deliveries.

Files
  • packages/db/src/schema.ts — adds the user_activity_tokens table, its unique token index, and its user-plus-organization index.
  • packages/db/src/migrations/0233_square_daimon_hellstrom.sql — creates the table, the user foreign key, and both indexes.
  • apps/web/src/lib/user/index.ts — deletes the user's activity-token rows in the soft-delete path.

Two new user mutations register and unregister activity tokens. registerActivityToken upserts on the token so a re-registration replaces the row, and unregisterActivityToken deletes only a row owned by the caller.

Files
  • apps/web/src/routers/user-router.ts — adds registerActivityToken and unregisterActivityToken and imports the new table.

The active-sessions core moves into a reusable server function. The tRPC procedure now delegates to listActiveSessions, which keeps the worker fetch, the enrichment, and the cloud-agent merge, so the snapshot builder can reuse it without a tRPC context.

Files
  • apps/web/src/lib/active-sessions-list.ts — new module holding the fetch, parse, enrich, and cloud-merge logic.
  • apps/web/src/routers/active-sessions-router.ts — the list procedure now calls listActiveSessions and re-exports its types.

A new internal route builds the privacy-minimal glanceable snapshot for a user. It requires the internal secret, re-checks organization membership when an organization is named, and returns the same versioned shape the mobile publisher derives locally. The builder reads only each session's status, so titles, ids, and other raw fields never leave the server.

Files
  • apps/web/src/app/api/internal/glanceable-agents-snapshot/route.ts — the secret-authenticated route with the organization re-check.
  • apps/web/src/lib/glanceable-agents-snapshot-server.ts — builds the snapshot from the active-sessions list through the shared builder.

A new push data variant active_agents_glanceable carries the aggregate snapshot. It has a versioned revision, an opaque scope key, counts, status, and safe timestamps, and never a title or id. A new active-agents Android channel and count-free generic copy route this payload.

Files
  • packages/notifications/src/push-data.ts — adds the variant and the GlanceableLiveActivityContentState type.
  • packages/notifications/src/push-presentation.ts — adds the channel and the routing and generic-copy cases.
  • packages/notifications/src/locales/en.json — adds the generic body string for the glanceable push.

The notifications worker now sends Live Activity APNs pushes and aggregate glanceable deliveries. A token-based APNs client signs a provider JWT and sends start or update pushes, and a pure orchestrator builds the snapshot and pushes it to iOS activity tokens and Expo tokens. After each cloud-agent session push, the worker delivers the fresh snapshot best-effort.

Files
  • services/notifications/src/lib/apns-live-activity.ts — new APNs client with JWT signing, request building, and parallel sending.
  • services/notifications/src/lib/glanceable-delivery.ts — new orchestrator whose IO is injected for tests.
  • services/notifications/src/index.ts — wires the dependencies, reads the credentials, and delivers after the session push.

The worker gains optional configuration for the snapshot and APNs delivery. KILO_WEB_API_BASE_URL names the web origin, and the four APNs values name the signing key and the topic. A missing value skips that part of delivery instead of failing the push.

Files
  • services/notifications/src/bindings.d.ts — declares the new optional bindings.
  • services/notifications/wrangler.jsonc — sets KILO_WEB_API_BASE_URL to the production origin.
  • ENVIRONMENT.md — documents the five new values.

The mobile app applies active_agents_glanceable pushes in the foreground and in a headless background task. A scope-key fence and an updatedAt check discard stale or foreign pushes, and the applied snapshot rebases its revision onto the local sequence and its local account epoch. The foreground handler suppresses these pushes as banners, and taps land on the Agents tab.

Files
  • apps/mobile/src/lib/notifications.ts — adds the apply logic, the background task, and the foreground suppression.
  • apps/mobile/src/lib/notification-path.ts — routes a glanceable tap to the Agents tab.
  • apps/mobile/src/app/_layout.tsx — registers the background handler at module scope.
  • apps/mobile/app.config.ts — enables background remote notifications.
  • apps/mobile/package.json — adds expo-task-manager.

An iOS delivery registrar registers and unregisters the Live Activity and push-to-start tokens. Registration waits for any in-flight logout unregister to settle, and unregistration reports the tokens it attempted so logout can tombstone them.

Files
  • apps/mobile/src/lib/glanceable/delivery-registration.ts — new registrar wiring the two token mutations.
  • apps/mobile/src/lib/glanceable/sink-registry.ts — adds the delivery hook and the token-only context.
  • apps/mobile/src/lib/auth/push-registration-reconciliation.ts — imports the registrar as a side effect.

The iOS Live Activity renders status, counts, and an elapsed timer from the shared content-state. The sink adopts an existing activity after a process restart, guards revisions, marks the surface denied only on a permanent ActivityKit failure, and triggers a one-time Settings prompt from the Agents tab.

Files
  • apps/mobile/src/glanceable-ios/active-agents-live-activity.tsx — the Live Activity layout with inlined English copy.
  • apps/mobile/src/glanceable-ios/ios-sink.ts — start, update, adopt, end, and token registration.
  • apps/mobile/src/glanceable-ios/view-props.ts — builds the surface props and the content-state.
  • apps/mobile/src/lib/glanceable/activity-kit-prompt.ts — the one-time Settings alert.
  • apps/mobile/src/app/(app)/(tabs)/(2_agents)/index.tsx — shows the alert when the tab regains focus.

Logout now awaits activity-token unregistration and tombstones a failed attempt. Reconciliation retries only the recorded tokens, marks the activity part done when it succeeds, and orders registration against the unregister so a new session's tokens are never re-deleted.

Files
  • apps/mobile/src/lib/auth/logout-cleanup.ts — extends the tombstone with activity tokens and awaits unregistration.
  • apps/mobile/src/lib/auth/logout-reconciliation.ts — retries the recorded tokens and marks the activity part done.

Tests: 14 test files updated across the mobile, web, and notifications suites.
Generated: 1 lockfile updated and 2 Drizzle migration metadata files regenerated.


Verification

No E2E report was attached for this section, and no manual tests were run.

Visual Changes

Visual Changes: N/A

Human steps:

  • after merge — set APNS_TEAM_ID, APNS_KEY_ID, APNS_PRIVATE_KEY, and APNS_TOPIC in the notifications Worker. Without them, iOS Live Activity delivery silently skips.

Notes: none.

Stacked PRs — merge bottom to top. Each level shows only its own diff.

Runtime verification (E2E, user advocacy, simplify) runs on the tip PR over every level.
Every level keeps its own checks, its own bot review, and its own threads; each one is answered on its own PR.
Each level is its own deliverable: it builds and passes its own checks alone.
A finding on a level is repaired on that level, then carried upward with stack.sh forward.

  1. audit-w8b-live-activities-3cf8feat(mobile): add glanceable agents snapshot contract #5535
  2. audit-w8b-live-activities-3cf8-s2feat(mobile): add iOS Live Activity and widgets #5553
  3. audit-w8b-live-activities-3cf8-s3feat(mobile): add Android agents widget and live update #5585
  4. audit-w8b-live-activities-3cf8-s4feat(mobile): deliver glanceable snapshot updates #5620 ← this PR (tip)

Add activity-token registration and background delivery so eligible work updates the iOS Live Activity, Android ongoing notification, and Home widgets without opening the app. Logout unregisters tokens. Old clients ignore the new payload type.
Comment thread apps/mobile/src/lib/notifications.ts
Comment thread apps/mobile/src/lib/glanceable/delivery-registration.ts Outdated
Comment thread apps/mobile/src/lib/glanceable/delivery-registration.ts Outdated
Comment thread services/notifications/src/lib/glanceable-delivery.ts Outdated
Comment thread services/notifications/src/lib/glanceable-delivery.ts
@kilo-code-bot

kilo-code-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

APNs team ID, key ID, and private-key Secrets Store binding are now declared on the notifications worker; remaining changes are docs, generated types, and import formatting.

Files Reviewed (5 files)
  • ENVIRONMENT.md
  • apps/mobile/src/lib/hooks/use-glanceable-preference.ts
  • services/notifications/worker-configuration.d.ts
  • services/notifications/wrangler.jsonc
  • services/session-ingest/src/notifications-bindings.d.ts
Previous Review Summaries (15 snapshots, latest commit 33674ef)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 33674ef)

Status: No Issues Found | Recommendation: Merge

Executive Summary

Active Agents master switch blanks surfaces and drops headless snapshots when off; APNs topic is declared in worker vars.

Files Reviewed (21 files)
  • ENVIRONMENT.md
  • apps/mobile/src/app/(app)/(tabs)/(2_agents)/index.mounted.test.tsx
  • apps/mobile/src/app/(app)/(tabs)/(2_agents)/index.tsx
  • apps/mobile/src/components/app-unlock-screen.test-helpers.tsx
  • apps/mobile/src/components/preferences-screen.mounted.test.tsx
  • apps/mobile/src/components/preferences-screen.tsx
  • apps/mobile/src/lib/auth/auth-context.test.tsx
  • apps/mobile/src/lib/auth/auth-context.tsx
  • apps/mobile/src/lib/auth/credentials.test.ts
  • apps/mobile/src/lib/glanceable/activity-kit-prompt.ts
  • apps/mobile/src/lib/glanceable/enabled.test.ts
  • apps/mobile/src/lib/glanceable/enabled.ts
  • apps/mobile/src/lib/glanceable/mount.tsx
  • apps/mobile/src/lib/hooks/use-glanceable-preference.ts
  • apps/mobile/src/lib/notifications.test.ts
  • apps/mobile/src/lib/notifications.ts
  • apps/mobile/src/lib/storage-keys.ts
  • services/notifications/src/lib/glanceable-delivery.test.ts
  • services/notifications/wrangler.jsonc
  • services/session-ingest/src/dos/UserConnectionDO.test.ts
  • services/session-ingest/src/notifications-bindings.d.ts

Previous review (commit 421a090)

Status: No Issues Found | Recommendation: Merge

Executive Summary

Credential-shaped glanceable-refresh error fixture was replaced with a generic string; the test still asserts queue ack and logs only the session id.

Files Reviewed (1 file)
  • services/cloud-agent-next/src/telemetry/report-consumer.glanceable.test.ts

Previous review (commit cee6acb)

Status: No Issues Found | Recommendation: Merge

Executive Summary

Terminal Live Activity ends now retire APNs targets under a generation fence before fresh work can start, with failed refresh isolated from queue ack.

Files Reviewed (6 files)
  • services/notifications/src/lib/apns-live-activity.ts
  • services/notifications/src/lib/apns-live-activity.test.ts
  • services/notifications/src/lib/glanceable-delivery-deps.ts
  • services/notifications/src/lib/glanceable-delivery.test.ts
  • services/notifications/src/lib/glanceable-delivery.ts
  • services/notifications/src/lib/glanceable-refresh.ts

Previous review (commit 35cf697)

Status: No Issues Found | Recommendation: Merge

Executive Summary

Committed Cloud Agent run reports now refresh glanceable counts after the report transaction, with failed refresh isolated so the queue still acks.

Files Reviewed (3 files)
  • services/cloud-agent-next/src/notifications-binding.ts
  • services/cloud-agent-next/src/telemetry/report-consumer.glanceable.test.ts
  • services/cloud-agent-next/src/telemetry/report-consumer.ts

Previous review (commit 7428272)

Status: No Issues Found | Recommendation: Merge

Executive Summary

Generation-fenced glanceable refresh now runs from session metadata, heartbeat, and disconnect transitions, with APNs timestamp ordering and Expo supersession checks covering the concurrent-delivery races.

Files Reviewed (18 files)
  • packages/notifications/src/rpc-schemas.test.ts
  • packages/notifications/src/rpc-schemas.ts
  • services/notifications/src/dos/NotificationChannelDO.ts
  • services/notifications/src/index.ts
  • services/notifications/src/lib/apns-live-activity.test.ts
  • services/notifications/src/lib/apns-live-activity.ts
  • services/notifications/src/lib/expo-push.test.ts
  • services/notifications/src/lib/expo-push.ts
  • services/notifications/src/lib/glanceable-delivery-deps.ts
  • services/notifications/src/lib/glanceable-delivery.test.ts
  • services/notifications/src/lib/glanceable-delivery.ts
  • services/notifications/src/lib/glanceable-refresh.ts
  • services/session-ingest/src/dos/UserConnectionDO.test.ts
  • services/session-ingest/src/dos/UserConnectionDO.ts
  • services/session-ingest/src/ingest/metadata.test.ts
  • services/session-ingest/src/ingest/metadata.ts
  • services/session-ingest/src/notifications-binding.ts
  • services/session-ingest/src/remote-session-notifications.ts

Previous review (commit 453669e)

Status: No Issues Found | Recommendation: Merge

Executive Summary

Idle ends now keep scope delivery registered so rotated Live Activity and Android tokens still update widgets after the visible surface goes away.

Files Reviewed (15 files)
  • apps/mobile/src/glanceable-android/android-sink.test.ts
  • apps/mobile/src/glanceable-android/android-sink.ts
  • apps/mobile/src/glanceable-ios/ios-sink.test.ts
  • apps/mobile/src/glanceable-ios/ios-sink.ts
  • apps/mobile/src/lib/auth/logout-cleanup.test.ts
  • apps/mobile/src/lib/auth/logout-cleanup.ts
  • apps/mobile/src/lib/glanceable/cleanup.ts
  • apps/mobile/src/lib/glanceable/delivery-registration.test.ts
  • apps/mobile/src/lib/glanceable/delivery-registration.ts
  • apps/mobile/src/lib/glanceable/publisher.ts
  • apps/mobile/src/lib/glanceable/sink-registry.ts
  • apps/mobile/src/lib/notifications.test.ts
  • patches/expo-widgets@57.0.11.patch
  • pnpm-lock.yaml
  • pnpm-workspace.yaml

Previous review (commit 2864988)

Status: No Issues Found | Recommendation: Merge

Executive Summary

Idle ActivityKit recovery now clears the denied latch after a verified identity read even when Agents is empty, and Android native deadlines hide expired counts without a JS timer.

Files Reviewed (15 files)
  • apps/mobile/modules/active-agents-live-update/android/src/main/AndroidManifest.xml
  • apps/mobile/modules/active-agents-live-update/android/src/main/java/com/kilocode/activeagentsliveupdate/ActiveAgentsDeadlineReceiver.kt
  • apps/mobile/modules/active-agents-live-update/android/src/main/java/com/kilocode/activeagentsliveupdate/ActiveAgentsLiveUpdateModule.kt
  • apps/mobile/src/glanceable-android/active-agents-widget.test.ts
  • apps/mobile/src/glanceable-android/android-sink.test.ts
  • apps/mobile/src/glanceable-android/android-sink.ts
  • apps/mobile/src/glanceable-android/live-update.ts
  • apps/mobile/src/glanceable-android/register.test.ts
  • apps/mobile/src/glanceable-android/register.ts
  • apps/mobile/src/glanceable-android/widget-props.test.ts
  • apps/mobile/src/glanceable-android/widget-props.ts
  • apps/mobile/src/lib/glanceable/activity-kit-prompt.test.ts
  • apps/mobile/src/lib/glanceable/activity-kit-prompt.ts
  • apps/mobile/src/lib/glanceable/presentation.test.ts
  • apps/mobile/src/lib/glanceable/presentation.ts

Previous review (commit a07b005)

Status: 1 Issue Found | Recommendation: Address before merge

Executive Summary

ActivityKit recovery no longer clears the denied latch unless eligible work is already present, so re-enabling Live Activities with an empty Agents tab never starts a later activity on that same focus.

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
apps/mobile/src/lib/glanceable/activity-kit-prompt.ts 66 Ineligible recovery leaves the ActivityKit denied latch set
Files Reviewed (5 files)
  • apps/mobile/src/app/(app)/(tabs)/(2_agents)/index.tsx
  • apps/mobile/src/glanceable-ios/ios-sink.ts
  • apps/mobile/src/i18n/locales/en.json
  • apps/mobile/src/lib/glanceable/activity-kit-prompt.test.ts
  • apps/mobile/src/lib/glanceable/activity-kit-prompt.ts - 1 issue

Fix these issues in Kilo Cloud

Previous review (commit 609fc68)

Status: 1 Issue Found | Recommendation: Address before merge

Executive Summary

ActivityKit recovery no longer clears the denied latch unless eligible work is already present, so re-enabling Live Activities with an empty Agents tab never starts a later activity on that same focus.

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
apps/mobile/src/lib/glanceable/activity-kit-prompt.ts 66 Ineligible recovery leaves the ActivityKit denied latch set
Files Reviewed (12 files)
  • apps/mobile/src/app/(app)/(tabs)/(2_agents)/index.mounted.test.tsx
  • apps/mobile/src/app/(app)/(tabs)/(2_agents)/index.tsx
  • apps/mobile/src/glanceable-ios/ios-sink.test.ts
  • apps/mobile/src/glanceable-ios/ios-sink.ts
  • apps/mobile/src/lib/glanceable/activity-kit-prompt.test.ts
  • apps/mobile/src/lib/glanceable/activity-kit-prompt.ts - 1 issue
  • apps/mobile/src/lib/glanceable/cleanup.test.ts
  • apps/mobile/src/lib/glanceable/cleanup.ts
  • apps/mobile/src/lib/glanceable/publisher.test.ts
  • apps/mobile/src/lib/glanceable/publisher.ts
  • apps/mobile/src/lib/notifications.test.ts
  • apps/mobile/src/lib/notifications.ts

Fix these issues in Kilo Cloud

Previous review (commit fa8897d)

Status: No Issues Found | Recommendation: Merge

Executive Summary

Incremental i18n-only change since the last review: glanceable mobile status keys and activeAgentsGlanceable notification copy are present in every locale with matching keys and no empty values.

Files Reviewed (172 files)
  • apps/mobile/src/i18n/locales/af.json
  • apps/mobile/src/i18n/locales/am.json
  • apps/mobile/src/i18n/locales/ar.json
  • apps/mobile/src/i18n/locales/az.json
  • apps/mobile/src/i18n/locales/be.json
  • apps/mobile/src/i18n/locales/bg.json
  • apps/mobile/src/i18n/locales/bn.json
  • apps/mobile/src/i18n/locales/bs.json
  • apps/mobile/src/i18n/locales/ca.json
  • apps/mobile/src/i18n/locales/ckb.json
  • apps/mobile/src/i18n/locales/cs.json
  • apps/mobile/src/i18n/locales/cy.json
  • apps/mobile/src/i18n/locales/da.json
  • apps/mobile/src/i18n/locales/de.json
  • apps/mobile/src/i18n/locales/el.json
  • apps/mobile/src/i18n/locales/es.json
  • apps/mobile/src/i18n/locales/et.json
  • apps/mobile/src/i18n/locales/eu.json
  • apps/mobile/src/i18n/locales/fa.json
  • apps/mobile/src/i18n/locales/fi.json
  • apps/mobile/src/i18n/locales/fil.json
  • apps/mobile/src/i18n/locales/fr.json
  • apps/mobile/src/i18n/locales/ga.json
  • apps/mobile/src/i18n/locales/gl.json
  • apps/mobile/src/i18n/locales/gu.json
  • apps/mobile/src/i18n/locales/ha.json
  • apps/mobile/src/i18n/locales/he.json
  • apps/mobile/src/i18n/locales/hi.json
  • apps/mobile/src/i18n/locales/hr.json
  • apps/mobile/src/i18n/locales/ht.json
  • apps/mobile/src/i18n/locales/hu.json
  • apps/mobile/src/i18n/locales/hy.json
  • apps/mobile/src/i18n/locales/id.json
  • apps/mobile/src/i18n/locales/ig.json
  • apps/mobile/src/i18n/locales/is.json
  • apps/mobile/src/i18n/locales/it.json
  • apps/mobile/src/i18n/locales/ja.json
  • apps/mobile/src/i18n/locales/ka.json
  • apps/mobile/src/i18n/locales/kk.json
  • apps/mobile/src/i18n/locales/km.json
  • apps/mobile/src/i18n/locales/kn.json
  • apps/mobile/src/i18n/locales/ko.json
  • apps/mobile/src/i18n/locales/lo.json
  • apps/mobile/src/i18n/locales/lt.json
  • apps/mobile/src/i18n/locales/lv.json
  • apps/mobile/src/i18n/locales/mg.json
  • apps/mobile/src/i18n/locales/mi.json
  • apps/mobile/src/i18n/locales/mk.json
  • apps/mobile/src/i18n/locales/ml.json
  • apps/mobile/src/i18n/locales/mn.json
  • apps/mobile/src/i18n/locales/mr.json
  • apps/mobile/src/i18n/locales/ms.json
  • apps/mobile/src/i18n/locales/mt.json
  • apps/mobile/src/i18n/locales/my.json
  • apps/mobile/src/i18n/locales/nb.json
  • apps/mobile/src/i18n/locales/ne.json
  • apps/mobile/src/i18n/locales/nl.json
  • apps/mobile/src/i18n/locales/om.json
  • apps/mobile/src/i18n/locales/or.json
  • apps/mobile/src/i18n/locales/pa.json
  • apps/mobile/src/i18n/locales/pl.json
  • apps/mobile/src/i18n/locales/ps.json
  • apps/mobile/src/i18n/locales/pt-BR.json
  • apps/mobile/src/i18n/locales/pt.json
  • apps/mobile/src/i18n/locales/ro.json
  • apps/mobile/src/i18n/locales/ru.json
  • apps/mobile/src/i18n/locales/si.json
  • apps/mobile/src/i18n/locales/sk.json
  • apps/mobile/src/i18n/locales/sl.json
  • apps/mobile/src/i18n/locales/so.json
  • apps/mobile/src/i18n/locales/sq.json
  • apps/mobile/src/i18n/locales/sr.json
  • apps/mobile/src/i18n/locales/sv.json
  • apps/mobile/src/i18n/locales/sw.json
  • apps/mobile/src/i18n/locales/ta.json
  • apps/mobile/src/i18n/locales/te.json
  • apps/mobile/src/i18n/locales/th.json
  • apps/mobile/src/i18n/locales/tr.json
  • apps/mobile/src/i18n/locales/uk.json
  • apps/mobile/src/i18n/locales/ur.json
  • apps/mobile/src/i18n/locales/uz.json
  • apps/mobile/src/i18n/locales/vi.json
  • apps/mobile/src/i18n/locales/yo.json
  • apps/mobile/src/i18n/locales/zh-Hans.json
  • apps/mobile/src/i18n/locales/zh-Hant.json
  • apps/mobile/src/i18n/locales/zu.json
  • packages/notifications/src/locales/af.json
  • packages/notifications/src/locales/am.json
  • packages/notifications/src/locales/ar.json
  • packages/notifications/src/locales/az.json
  • packages/notifications/src/locales/be.json
  • packages/notifications/src/locales/bg.json
  • packages/notifications/src/locales/bn.json
  • packages/notifications/src/locales/bs.json
  • packages/notifications/src/locales/ca.json
  • packages/notifications/src/locales/ckb.json
  • packages/notifications/src/locales/cs.json
  • packages/notifications/src/locales/cy.json
  • packages/notifications/src/locales/da.json
  • packages/notifications/src/locales/de.json
  • packages/notifications/src/locales/el.json
  • packages/notifications/src/locales/es.json
  • packages/notifications/src/locales/et.json
  • packages/notifications/src/locales/eu.json
  • packages/notifications/src/locales/fa.json
  • packages/notifications/src/locales/fi.json
  • packages/notifications/src/locales/fil.json
  • packages/notifications/src/locales/fr.json
  • packages/notifications/src/locales/ga.json
  • packages/notifications/src/locales/gl.json
  • packages/notifications/src/locales/gu.json
  • packages/notifications/src/locales/ha.json
  • packages/notifications/src/locales/he.json
  • packages/notifications/src/locales/hi.json
  • packages/notifications/src/locales/hr.json
  • packages/notifications/src/locales/ht.json
  • packages/notifications/src/locales/hu.json
  • packages/notifications/src/locales/hy.json
  • packages/notifications/src/locales/id.json
  • packages/notifications/src/locales/ig.json
  • packages/notifications/src/locales/is.json
  • packages/notifications/src/locales/it.json
  • packages/notifications/src/locales/ja.json
  • packages/notifications/src/locales/ka.json
  • packages/notifications/src/locales/kk.json
  • packages/notifications/src/locales/km.json
  • packages/notifications/src/locales/kn.json
  • packages/notifications/src/locales/ko.json
  • packages/notifications/src/locales/lo.json
  • packages/notifications/src/locales/lt.json
  • packages/notifications/src/locales/lv.json
  • packages/notifications/src/locales/mg.json
  • packages/notifications/src/locales/mi.json
  • packages/notifications/src/locales/mk.json
  • packages/notifications/src/locales/ml.json
  • packages/notifications/src/locales/mn.json
  • packages/notifications/src/locales/mr.json
  • packages/notifications/src/locales/ms.json
  • packages/notifications/src/locales/mt.json
  • packages/notifications/src/locales/my.json
  • packages/notifications/src/locales/nb.json
  • packages/notifications/src/locales/ne.json
  • packages/notifications/src/locales/nl.json
  • packages/notifications/src/locales/om.json
  • packages/notifications/src/locales/or.json
  • packages/notifications/src/locales/pa.json
  • packages/notifications/src/locales/pl.json
  • packages/notifications/src/locales/ps.json
  • packages/notifications/src/locales/pt-BR.json
  • packages/notifications/src/locales/pt.json
  • packages/notifications/src/locales/ro.json
  • packages/notifications/src/locales/ru.json
  • packages/notifications/src/locales/si.json
  • packages/notifications/src/locales/sk.json
  • packages/notifications/src/locales/sl.json
  • packages/notifications/src/locales/so.json
  • packages/notifications/src/locales/sq.json
  • packages/notifications/src/locales/sr.json
  • packages/notifications/src/locales/sv.json
  • packages/notifications/src/locales/sw.json
  • packages/notifications/src/locales/ta.json
  • packages/notifications/src/locales/te.json
  • packages/notifications/src/locales/th.json
  • packages/notifications/src/locales/tr.json
  • packages/notifications/src/locales/uk.json
  • packages/notifications/src/locales/ur.json
  • packages/notifications/src/locales/uz.json
  • packages/notifications/src/locales/vi.json
  • packages/notifications/src/locales/yo.json
  • packages/notifications/src/locales/zh-Hans.json
  • packages/notifications/src/locales/zh-Hant.json
  • packages/notifications/src/locales/zu.json

Previous review (commit 5853a07)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • apps/mobile/src/app/(app)/(tabs)/(2_agents)/index.mounted.test.tsx

Previous review (commit 05664ca)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (6 files)
  • apps/mobile/src/lib/auth/logout-cleanup.test.ts
  • apps/mobile/src/lib/auth/logout-cleanup.ts
  • apps/mobile/src/lib/auth/logout-reconciliation.test.ts
  • apps/mobile/src/lib/auth/logout-reconciliation.ts
  • apps/mobile/src/lib/glanceable/delivery-registration.test.ts
  • apps/mobile/src/lib/glanceable/delivery-registration.ts

Previous review (commit fe6f60a)

Status: 3 Issues Found | Recommendation: Address before merge

Executive Summary

Failed activity-token unregister on account/org switch still overwrites a pending push-token tombstone, and org-switch registration can still race the fire-and-forget delete.

Overview

Severity Count
CRITICAL 0
WARNING 3
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
apps/mobile/src/lib/auth/logout-cleanup.ts 191 Failed switch unregister overwrites a pending push-token tombstone
apps/mobile/src/lib/organization-context.tsx 78 Org-switch token unregister is fire-and-forget, so the new org can re-register before delete settles
apps/mobile/src/lib/auth/logout-reconciliation.ts 96 hasPendingActivityUnregister treats another user's tombstone as blocking
Files Reviewed (6 files)
  • apps/mobile/knip.json
  • apps/mobile/src/glanceable-android/register.test.ts
  • apps/mobile/src/glanceable-android/register.ts
  • apps/mobile/src/glanceable-ios/ios-sink.test.ts
  • apps/mobile/src/glanceable-ios/ios-sink.ts
  • apps/mobile/src/lib/unread-counts-invalidation-mount.test.ts

Fix these issues in Kilo Cloud

Previous review (commit caf4017)

Status: 5 Issues Found | Recommendation: Address before merge

Executive Summary

Failed activity-token unregister on account/org switch still overwrites a pending push-token tombstone, and org-switch registration can still race the fire-and-forget delete.

Overview

Severity Count
CRITICAL 0
WARNING 5
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
apps/mobile/src/lib/auth/logout-cleanup.ts 191 Failed switch unregister overwrites a pending push-token tombstone
apps/mobile/src/lib/organization-context.tsx 78 Org-switch token unregister is fire-and-forget, so the new org can re-register before delete settles
apps/mobile/src/glanceable-ios/ios-sink.ts 97 Async endNow leaves the Live Activity handle live across an await
apps/mobile/src/glanceable-android/register.ts 51 Restored widget snapshot ignores expiresAt after process death
apps/mobile/src/lib/auth/logout-reconciliation.ts 96 hasPendingActivityUnregister treats another user's tombstone as blocking
Files Reviewed (8 files)
  • apps/mobile/src/lib/auth/logout-reconciliation.test.ts
  • apps/mobile/src/lib/auth/logout-reconciliation.ts - 1 issue
  • apps/mobile/src/lib/glanceable/activity-kit-prompt.ts
  • apps/mobile/src/lib/glanceable/delivery-registration.test.ts
  • apps/mobile/src/lib/glanceable/delivery-registration.ts
  • apps/mobile/src/lib/glanceable/sink-registry.ts
  • services/notifications/src/lib/glanceable-delivery.test.ts
  • services/notifications/src/lib/glanceable-delivery.ts

Fix these issues in Kilo Cloud

Previous review (commit 3367927)

Status: 8 Issues Found | Recommendation: Address before merge

Executive Summary

Failed activity-token unregister on account/org switch overwrites a pending push-token tombstone, and org-switch registration can race the fire-and-forget delete.

Overview

Severity Count
CRITICAL 0
WARNING 8
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
apps/mobile/src/lib/auth/logout-cleanup.ts 191 Failed switch unregister overwrites a pending push-token tombstone
apps/mobile/src/lib/organization-context.tsx 78 Org-switch token unregister is fire-and-forget, so the new org can re-register before delete settles
apps/mobile/src/glanceable-ios/ios-sink.ts 229 Async endNow leaves the Live Activity handle live across an await
apps/mobile/src/lib/notifications.ts 156 Headless empty snapshot still never ends the Live Activity: the 8s timer is scheduled then the background task returns
apps/mobile/src/lib/glanceable/delivery-registration.ts 183 Token registration proceeds when logout reconciliation is spacing-skipped
`apps/m

[Snapshot truncated.]

Additional previous summary content was truncated to keep this comment within platform limits.


Reviewed by grok-4.6 · Input: 100.1K · Output: 6.9K · Cached: 202.4K

Review guidance: REVIEW.md from base branch audit-w8b-live-activities-3cf8-s3

iscekic added 19 commits August 27, 2026 21:57
…activities-3cf8-s4

# Conflicts:
#	apps/mobile/src/lib/auth/logout-cleanup.ts
#	apps/mobile/src/lib/notifications.test.ts
#	apps/mobile/src/lib/notifications.ts
#	packages/db/src/migrations/meta/0233_snapshot.json
#	packages/db/src/migrations/meta/_journal.json
iscekic added 14 commits August 28, 2026 11:44
Submit the Live Activity end during publish so ActivityKit owns removal
after the push handler returns. Track pending native ends by ActivityKit
ID, not by a JS counter, so a recreated wrapper cannot restart a dying
activity. Patch expo-widgets for getInfo() and getInstances(includeEnded)
to read native state and reach terminal-retained instances on privacy.
…activities-3cf8-s4

# Conflicts:
#	apps/mobile/package.json
#	apps/mobile/src/lib/notifications.test.ts
#	apps/mobile/src/lib/organization-context.tsx
#	packages/db/src/migrations/meta/0234_snapshot.json
#	packages/db/src/migrations/meta/_journal.json
#	pnpm-lock.yaml
#	services/session-ingest/src/ingest/metadata.test.ts
@iscekic
iscekic force-pushed the audit-w8b-live-activities-3cf8-s4 branch from 421a090 to e9bd7b6 Compare September 2, 2026 13:21
iscekic and others added 4 commits September 2, 2026 16:03
Add a master switch for the glanceable Active Agents surfaces. Off blanks
every surface, unregisters its push tokens, refuses the in-app publisher,
drops remote snapshots in the headless push handler, and never prompts for
ActivityKit permission.

Declare the APNs Live Activity vars in the notifications worker config and
document what still has to land before the deploy: the .p8 auth key in the
Secrets Store, then its binding.

Fix the session-ingest typecheck. Its DO tests import the notifications
sources, which read bindings off a global `Env` this package does not have.
Register a team-scoped APNs auth key (KRYMZL626P, sandbox and production)
and store the .p8 in the Secrets Store. Declare the team and key ids as
vars, bind the private key, and regenerate the Worker bindings.

Live Activity push now has every value it needs. A backup of the .p8 is in
the 1Password "Eng / Product" vault; Apple never serves it a second time.
The app-side consumer of `dev_session_token` was deleted in #5641, so the
script printed a successful sign-in and the app stayed on the login screen.
Nothing else imports it.
Replace the four-state count model with three states the user named: needs
input (orange), working (green), and idle (white). The `retry` status folds
into needs input, because it means one thing to the user: the agent waits and
cannot go on alone. The "Reconnecting" label is gone.

The Dynamic Island now shows the Kilo mark and one number, colored by the state
it counts and ranked needs-input, working, idle. The Lock Screen banner and
every widget family show one row per non-zero state, each with a glyph whose
shape differs as well as its color, so the state reads in the accented Lock
Screen rendering too. The "Open agents" line is gone from every surface; the
whole surface already deep-links there, so the label stays in the spoken text.

Copy the Kilo mark into the shared app group and bake its path into the
stringified `'widget'` layouts, because the widget extension cannot resolve a
bundle asset and the notifications Worker cannot know a device path.

Fix two defects the redesign uncovered:

- The layouts referenced the imported `WIDGET_LOGO_PLACEHOLDER`, which is an
  undefined global once the layout source is re-evaluated in the widget
  process. Each layout now repeats the literal, and a test keeps the copies
  equal.
- Widget props carried null fields. `updateTimeline` writes them to the shared
  `UserDefaults`, which rejects a null and threw out through the host function,
  so no widget family ever rendered. `toWidgetProps` omits them.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AGsBUddy4TP7xqJ58X8xiY
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant