Skip to content

Convert sphinx to zensical - #611

Open
popescu-v wants to merge 14 commits into
mainfrom
convert-sphinx-to-zensical
Open

Convert sphinx to zensical#611
popescu-v wants to merge 14 commits into
mainfrom
convert-sphinx-to-zensical

Conversation

@popescu-v

@popescu-v popescu-v commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Put your message here


TODO Before Asking for a Review

  • Rebase your branch to the latest version of main (or main-v10)
  • Make sure all CI workflows are green
  • When adding a public feature/fix: Update the Unreleased section of CHANGELOG.md (no date)
  • Self-Review: Review "Files Changed" tab and fix any problems you find
  • API Docs (only if there are changes in docstrings, rst files or samples):
    • Check the docs build without warning: see the log of the API Docs workflow
    • Check that your changes render well in HTML: download the API Docs artifact and open index.html
    • If there are any problems it is faster to iterate by building locally the API Docs

…ical

- don't release the Python API docs anymore: they are build in khiops-doc;
- have create-doc only prepare the build environment when asked; this allows
  code sharing with khiops-doc which only needs the preparation part;
- add minor path updates for the move from Sphinx to MkDocs;
- correctly extract Pip package version from RFC-822 metadata;
- inject samples version in the integration test jobs' environment; without this
  change, the default branch of the khiops-samples repository was being
  used on non-workflow dispatch events;
- drop spurious "toml" build-time dependency for Python >= 3.12; since
  Python 3.11, TOML parsing features are supported via the
  standard-library `tomllib` module;
- build docs in strict mode to fail on broken links;
- log tutorial conversion execution errors but continue the conversion;
- attempt to silence IPKernel warnings on tutorial conversion;
- drop versioning hook, unsupported by Zensical; inject the version
  through the create-doc build script instead;
- copy samples Python and Notebook code to the doc/ dir for file
  locality; Zensical fails to include the samples otherwise, because
  they are outside the doc/ build dir;
- inject current Khiops Python version into the site build;
- build site outside the doc dir, as per Zensical hard constraint;
  contrary to Sphinx, Zensical does not support having the site built
  inside the doc dir;
- exclude doc/README.md from the build;
- update doc READMEs and relevant Copilot instructions.
Zensical does not support file exclusion lists or wildcards. Hence, the
separation needs to be done upfront.
@popescu-v
popescu-v force-pushed the convert-sphinx-to-zensical branch 5 times, most recently from 851f07d to ff150f0 Compare August 18, 2026 12:05
Use active Uv virtual environment in doc/utils/create-doc to allow its
invocation from "enclosing" khiops-doc environments.

Run the api-docs workflow directly on the GitHub runner; the specific
Docker image is no longer needed.
@popescu-v
popescu-v force-pushed the convert-sphinx-to-zensical branch from ff150f0 to 947bf80 Compare August 18, 2026 12:17
@popescu-v
popescu-v requested a review from tramora August 18, 2026 12:45
@popescu-v
popescu-v force-pushed the convert-sphinx-to-zensical branch from 947bf80 to 3e3b40b Compare August 18, 2026 12:55
@popescu-v
popescu-v marked this pull request as ready for review August 18, 2026 12:56
Comment thread khiops/sklearn/dataset.py Outdated
Returns
-------
`.Dictionary`:
[`Dictionary`][]:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit surprised by the new syntax of link-like reference without any link in the second group of brackets

Comment thread .github/workflows/api-docs.yml
Comment thread .github/workflows/api-docs.yml

@tramora tramora left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking remarks so far. I just put minor comments that can be ignored.

It no longer points to a PDF file, but to a Markdown-based page.

@bruno-at-orange bruno-at-orange left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@popescu-v
popescu-v force-pushed the convert-sphinx-to-zensical branch from 9ce3cb2 to 812e44a Compare August 27, 2026 14:50
# supported by khiops, but this should pose no issue in practice)
# TODO: Revert as soon as issue
# https://github.com/KhiopsML/khiops-python/issues/602 is tackled
uv run kh-status || true

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TODO is legit but with the installation under uv we don't get an Error but a Warning instead.
In this case kh-status still returns a 0 code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants