Add omit_unreferenced_implementations config option (#416)#419
Open
WillAbides wants to merge 12 commits into
Open
Add omit_unreferenced_implementations config option (#416)#419WillAbides wants to merge 12 commits into
omit_unreferenced_implementations config option (#416)#419WillAbides wants to merge 12 commits into
Conversation
ef1b6aa to
65cb67e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #416
Adds an opt-in
omit_unreferenced_implementationsconfig option that collapses unfragmented interface/union implementations into a single catch-all struct per interface selection.With
omit_unreferenced_implementations: true:<…>GenqlientOtheris generated for each interface/union selection. It carries the interface's shared fields and satisfies the generated Go interface like any other impl. I chose the "GenqlientOther" suffix because it is very unlikely to be used in a real query.falsefor backward compatibility.Tests
Buildsubtest confirms each snapshot compiles.internal/integration/omitimpls/that exercises both the typed-impl path and the catch-all path end-to-end against the existing gqlgen test server.I have: