Skip to content

fix(judge): retry unusable json mode responses - #220

Draft
adity982 wants to merge 1 commit into
KeyValueSoftwareSystems:masterfrom
adity982:fix/json-mode-empty-verdict
Draft

fix(judge): retry unusable json mode responses#220
adity982 wants to merge 1 commit into
KeyValueSoftwareSystems:masterfrom
adity982:fix/json-mode-empty-verdict

Conversation

@adity982

Copy link
Copy Markdown

Summary

  • let the OpenAI-compatible completion helper validate extracted JSON for its caller
  • when JSON mode returns an unusable judge payload such as {}, retry exactly once without response_format
  • keep the second response as the terminal result and add regression coverage proving the fallback request omits JSON mode

Validation

  • full core suite: 167 tests, 164 passed, 3 expected skips
  • repository pre-commit hook: typecheck, lint, repo-wide Prettier, catalog generation, skill validation, and gitleaks

Closes #165

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ce1e6e59-d813-410b-89ae-dc5fea024a4d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jithin23-kv

Copy link
Copy Markdown
Collaborator

Hi @adity982, appreciate you contributing to Agent Opfor.
I noticed this PR is still marked as a draft. Are you still working on more changes, or is it ready to be marked as ready for review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: judge reports terminal ERROR on openai-compatible providers that return valid-but-empty JSON in json_object mode

2 participants