fix: 찌르기 버튼 비활성화일 때 터치 시 토스트 메시지 미노출#341
Merged
Merged
Conversation
Member
|
@coderabbitai summary |
clxxrlove
approved these changes
Jun 3, 2026
| if state != .disabled { | ||
| onTap() | ||
| } | ||
| onTap() |
Member
There was a problem hiding this comment.
이게 비활성 상태에서 토스트를 보여줘야 해서 disabled에서도 onTap을 둔걸로 보이는데, 이게 shared 컴포넌트라 여기서 수정하는거보다는, 필요한 callsite에서 별도로 opt-in 처리하는게 더 나을 거 같아
Contributor
Author
There was a problem hiding this comment.
마지막 PR에서 반영할게
shared 컴포넌트 수정 아예 없이 가려면 호출부에서 overlay로 clear한 영역 덮어야하는데 부자연스럽다고 생각해서 TXButton에 allowsActionWhenDisabled 파라미터 추가해서 Component 조금 수정할테니 확인하고 의견줘!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 관련 이슈
📙 작업 내역
🎨 스크린샷 또는 시연 영상 (선택)
2026-06-01.8.37.18.mov