Repository navigation
fix(parity): align week-grid macOS capture with web demo seed and scroll - #4670
Closed
tyler-dane wants to merge 1 commit into
Closed
tyler-dane wants to merge 1 commit into
tyler-dane wants to merge 1 commit into
Conversation
tyler-dane
added
agent-automerge
Cursor
tyler-dane
enabled auto-merge
October 21, 2026 11:07
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/mac-parity-week-grid-capture-2ef3
branch
from
October 21, 2026 11:08
0cae389 to
1c6521b
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 21, 2026
Contributor
Author
|
agent-loop: still conflicting after update-branch onto main. Closing so the issue can be relaunched. |
tyler-dane
removed
the
agent-automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4657
What and why
Week-grid compare PNGs still diverged on demo banner visibility, scroll origin, missing
Lunch with Sam, grid chrome, sidebar tips, and Up Next layout. Most gaps were capture-setup (web banner dismiss, scroll math, crop bands, mac parity chrome) plus mac timed-grid gutter/top rule matching web.buttonrole); instant scroll usingdemo-seed.jsonreferenceNow; assertLunch with Sambefore capture.tafter viewport settles; assert Lunch + Exercise; parity presentation discards grid drafts and pinsfocus-page-jumpfooter tip like web idle sidebar.WEB_GRID_REGION_TOP).TimeGridView: hour-gutter top offset and timed-grid top rule; past-column surface tint unchanged.UpNextCard: min height and chip padding aligned with web card density.Verify
Local:
bun run verify --strict— web/unit/a11y/parity e2e specs pass; one unrelated flake inshift-hold-event-hints.spec.ts(focus timeout) on this VM. macOS Swift builds CI-only.Pending:
desktop-web-parity-screenshotson this PR for updatedweek-grid-*-compare.pngartifacts.