Skip to content

fix(web): reserve inline space for description link keycaps - #4661

Merged
tyler-dane merged 1 commit into
mainfrom
cursor/fix-link-keycap-overlap-3cf9
Oct 21, 2026
Merged

tyler-dane merged 1 commit into
mainfrom
cursor/fix-link-keycap-overlap-3cf9

Conversation

@tyler-dane

Copy link
Copy Markdown
Contributor

Fixes overlap where digit keycaps sat on top of text after an inline link (e.g. one.example + 1 covering with notes).

  • Always reserve 1.75rem inline padding on description links when link shortcuts are enabled (c-description-link-hints), so toggling hints does not shift surrounding text.
  • Position floating keycap chips inside that slot instead of after the link glyph box.

Verify

bun test (DescriptionEditor link UX) — pass locally.

VERDICT: INCOMPLETE (CI pending)

Open in Web Open in Cursor 

Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
@tyler-dane tyler-dane added the agent-automerge Agent-loop finished; merge-guard may squash-merge label Oct 21, 2026 — with Cursor
@tyler-dane
tyler-dane enabled auto-merge October 21, 2026 01:25
@github-actions

Copy link
Copy Markdown
Contributor

Boot bundle: 509.3 KB gzip (+0.0 KB vs main)

@tyler-dane
tyler-dane added this pull request to the merge queue Oct 21, 2026
Merged via the queue into main with commit e0a9270 Oct 21, 2026
31 of 32 checks passed
@tyler-dane
tyler-dane deleted the cursor/fix-link-keycap-overlap-3cf9 branch October 21, 2026 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-automerge Agent-loop finished; merge-guard may squash-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants