Repository navigation
fix(macos): match web's Life quote and date of birth format - #4658
Merged
Merged
Conversation
The Life sidebar shows one random quote from web's 50 quotes (it was always the Franklin line), and the date of birth reads Jun 10, 2026 like web's picker. Typing accepts that or yyyy-mm-dd. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
tyler-dane
marked this pull request as ready for review
October 21, 2026 01:11
tyler-dane
added
the
agent-automerge
tyler-dane
enabled auto-merge
October 21, 2026 01:11
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Oct 21, 2026
tyler-dane
added a commit
that referenced
this pull request
Oct 21, 2026
…cker Resolves conflicts after #4658 merged: keeps the date of birth picker state and the stored(from:) helper on top of that PR's date format. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #4215
What and why
Two differences in the macOS Life sidebar versus web
LifeSidebarContentandLifeQuote:LIFE_QUOTES).LifeQuotesmirrors that list (generated fromlife-quotes.ts, not retyped) and the sidebar picks one per visit.MMM d, yyyy. The field now reads "Jun 10, 2026", and typing accepts that (comma optional, month case-insensitive) oryyyy-mm-dd. The stored value staysyyyy-mm-dd, and the 1900-through-today validation is unchanged. Invalid input such as "Feb 31, 2026" shows the existing error.Not included: web's calendar popup with a year picker for the date of birth. That is a larger piece of work.
Verify
CompassKit has three new tests: the quote list matches web (50, each attributed), display formatting, and typed parsing of both formats. CompassUI builds. The existing Life snapshot UI test, which types dates into this field, still passes.
bun run verify --strict: VERDICT: FAIL. Checks run: test:macos:packages, type-check, lint, knip, test:macos. The only failure isNativeLaunchTests.testEventClickShowsPointerHintWithoutOpening, which also fails on a cleanorigin/maincheckout on this machine and passed in CI on the earlier merged parity PRs (local state, unrelated). All other macOS tests pass.🤖 Generated with Claude Code