Repository navigation
fix(macos): use web's month grid for the form date picker - #4656
Merged
Merged
Conversation
The event form date popover was the system graphical DatePicker. It now reuses the sidebar month picker (Rubik, ink circle on the selection, Go to this month, Sunday first), with clickable days, and picking a day keeps the time of day. The time field drops its up/down caret, which web's field does not have. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
tyler-dane
marked this pull request as ready for review
October 21, 2026 01:03
tyler-dane
added
the
agent-automerge
tyler-dane
enabled auto-merge
October 21, 2026 01:03
tyler-dane
added a commit
that referenced
this pull request
Oct 21, 2026
…cker Resolves the SidebarMonthPicker conflict after #4656 merged: keeps this branch's caption picker and range properties on top of that PR's clickable days. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #4215
What and why
Pickers in the macOS event form differed from web:
DatePicker. It now reuses the sidebar month picker, the same web-styled grid (Rubik, ink circle on the selected day, Go to this month, Sunday first).SidebarMonthPickergains an opt-indaysAreClickable(sidebar days stay keyboard-only, as on web) and a header-less initializer. Picking a day changes the calendar day only and keeps the time of day.The popover opens as before (double-click on the date field), so typing a date is unaffected. The CI parity capture cannot show macOS popovers (separate windows), so this was compared from source.
Verify
CompassUI has two new unit tests for the keep-the-time rule (34 tests pass). The app target builds.
bun run verify --strict: VERDICT: FAIL. Checks run: test:macos:packages, type-check, lint, knip, test:macos. The only failure isNativeLaunchTests.testEventClickShowsPointerHintWithoutOpening, which also fails on a cleanorigin/maincheckout on this machine and passed in CI on the earlier merged parity PRs (local state, unrelated). All other macOS tests pass.🤖 Generated with Claude Code