Repository navigation
fix(macos): add description placeholder and draft delete like web - #4654
Merged
Merged
Conversation
The description text view shows web's Description placeholder while empty. A new draft gets web's trash button, which closes the form (with the discard prompt when edited) since nothing is saved yet. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
tyler-dane
marked this pull request as ready for review
October 21, 2026 00:46
tyler-dane
added
the
agent-automerge
tyler-dane
enabled auto-merge
October 21, 2026 00:46
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
…draw Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #4215
What and why
Two small event-form gaps found in the latest web vs macOS parity capture:
DescriptionEditorshows "Description" while empty.NSTextViewhas no placeholder, soDescriptionTextViewnow draws it (60% text color) while the string is empty and no IME composition is in progress.FormActionsRowshows the trash button on a new draft too, andhandleEventFormDeletecloses the form because nothing is saved. macOS only showed Delete for existing events. A new, writable draft now gets the same button, which callsrequestCloseEventForm(), so the discard prompt still appears if the draft was edited.Verify
CompassUI and the app target build.
bun run verify --strict: VERDICT: FAIL. Checks run: test:macos:packages, type-check, lint, knip, test:macos. The only failure isNativeLaunchTests.testEventClickShowsPointerHintWithoutOpening, which also fails on a cleanorigin/maincheckout on this machine and passed in CI on the earlier merged parity PRs (local state, unrelated). All other macOS tests pass.🤖 Generated with Claude Code
Summary
Brings the macOS event form in line with web for empty descriptions and new drafts:
DescriptionEditorContainerViewsoDescriptionTextViewbehavior matches main).Merged
mainso description-link, parity capture, and Swift package fixes from recent merges are included.CI root cause (was red ~13h)
swift-packages: Stale branch missed main’s description editor fixes; initial placeholder useddraw(_:)onDescriptionTextView, which brokeDescriptionEditorTests(emoji+bold list HTML and read-only font assertions). Fixed by container-based placeholder and keepingDescriptionTextViewidentical to main.macosgate: Failed becauseswift-packagesfailed.macos-capture/ parity: Earlier run hit a title-bar capture flake (mac-title-bar.pngtraffic lights); latest run skips capture when path filters say parity surfaces unchanged.Verify
VERDICT: PASS(bun run verify --stricton agent VM; Swift legs on macOS CI run 39619179975).Fixes form-details parity work for #4654.