Repository navigation
fix(macos): replace the feedback alert with a web-style dialog - #4652
Merged
Merged
Conversation
Share Feedback now opens an in-app 480pt modal like web FeedbackDialog: a labeled text area capped at 5000 characters, the account and session note, and Cancel (Esc) and Send feedback (Mod+Enter) actions. A send shows the thanks toast, and a failure keeps the dialog open with an error toast so the text is not lost. The Help menu and palette row share it, and the system NSAlert panel is removed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
tyler-dane
marked this pull request as ready for review
October 20, 2026 22:12
tyler-dane
added
the
agent-automerge
tyler-dane
enabled auto-merge
October 20, 2026 22:12
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #4215
What and why
"Share Feedback" opened a system
NSAlertwith a plain text field, while web opensFeedbackDialog(OverlayPanelmodal). This replaces the alert with an in-app dialog that matches web:The Help menu item and the command palette "Share Feedback" row open the same dialog. Router branch: while the dialog is open, Esc closes it and every other key goes to the text view, so calendar shortcuts cannot fire while typing. The submit path (
PostHogCapture.submitFeedback) is unchanged.CompassFeedbackPanelis deleted.Verify
CompassData has four new
FeedbackDialogTests(palette row opens it, send trims and closes with the thanks toast, failure keeps it open with an error toast, blank text is not sent). The app target and CompassUI build.bun run verify --strict: VERDICT: FAIL. Checks run: test:macos:packages, type-check, lint, knip, test:macos. The only failure isNativeLaunchTests.testEventClickShowsPointerHintWithoutOpening, which also fails on a cleanorigin/maincheckout on this machine and passed in CI on the earlier merged PRs (local state, unrelated). All other macOS tests pass.🤖 Generated with Claude Code