Repository navigation
fix(macos): add web notices, connection and timezone banners - #4640
Merged
Merged
Conversation
Port the local-mode trial card (S, Esc), the sidebar meeting-page nudge (M), and the sample-events banner O key from web. Count anonymous writes and shortcuts like web anon-explorer engagement, and let shortcut-only explorers skip the first-event card. Completes the first-event card on the first real create, which macOS never did, and makes demo banner dismissal observable so it re-renders. Restyles the first-event card to the web floating notice shell. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Port web CalendarConnectionBanner (reconnect, admin consent, failed import, delayed; G runs the action) and TimezoneMismatchBanner (switch to the device zone or keep the pinned one). Auto timezone now follows a Mac timezone change on the minute refresh, like web's browser-zone poll. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tyler-dane
marked this pull request as ready for review
October 20, 2026 21:55
tyler-dane
added
the
agent-automerge
tyler-dane
enabled auto-merge
October 20, 2026 21:55
tyler-dane
disabled auto-merge
October 20, 2026 22:02
Contributor
Author
|
agent-loop: still conflicting after update-branch onto main. Closing so the issue can be relaunched. |
tyler-dane
removed
the
agent-automerge
Resolves the RootView conflict with the unified title bar: the header moved out of the content column, the connection and timezone banners stay at its top. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
tyler-dane
added
the
agent-automerge
tyler-dane
enabled auto-merge
October 20, 2026 22:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #4215
What and why
Several web notices did not exist on macOS, and one existing one was quietly broken:
CalendarConnectionBanner). This adds Reconnect, Learn more (admin consent), Retry (failed first import), and Refresh (delayed) under the header.Gruns the action. Before this, a signed-in Mac user whose Google access lapsed got no prompt at all.TimezoneMismatchBanner). This adds Switch to device zone or Keep pinned zone, with the snooze stored per device zone. Auto timezone now also follows a Mac timezone change on the minute refresh, matching web's 60s browser-zone poll. Before this,refreshBrowserTimeZonewas never called.LocalModeConnectPrompt). It appears after one anonymous write or five shortcuts.Sstarts the trial and Esc dismisses. Shortcut-only explorers skip the first-event card, as on web.MeetingPageNudge). It shows after the first event until a meeting page is live or the nudge is dismissed.Mopens Meeting settings.useNoticeActionShortcut):G,O,M,S. They stand down during event jump, an armedesequence, or an open draft.pnotice focus now cycles through the new notices too.noteRealEventCreated, so the card never celebrated or retired after a create.EventsStorenow reports landed writes, which drives this and the anonymous write count. Undo restores are excluded.Onow dismisses it.Ckeycap). Header banners now sit inside the main column's 32pt leading inset, as on web.Verify
swift test --package-path CompassData: 216 passed. CompassKit tests pass, including newAnonymousExplorerEngagementTests,CalendarConnectionBannerTests, andTimezoneMismatchTests. The app target builds with xcodebuild.bun run verify --strict(after merging the newmaininto this branch to resolve a docs conflict): VERDICT: FAIL. Checks run: test:macos:packages, type-check, lint, knip, test:macos. The only failure isNativeLaunchTests.testEventClickShowsPointerHintWithoutOpening, which also fails on a cleanorigin/maincheckout on this machine and passed in CI on the five PRs already merged (local state, unrelated). All other macOS tests pass, including the new notice, banner, and timezone tests.🤖 Generated with Claude Code