Repository navigation
fix(web): repair event form time menu, date entry, and header spacing - #4541
Merged
Merged
Conversation
The time menu portal moved the menu outside .c-time-picker, so it lost its theme styles and the scroll-to-selected lookup found nothing. Reach the menu through the combobox and keep its chrome in react-select styles. The date field dropped typed dates on Tab or click-away and toasted on an empty Enter. Commit changed dates on Enter, Tab, and blur, quietly restore an emptied field, and select the text on focus so typing replaces it. Add top padding above the form's delete and close icons. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K3ak96Nsi73tTQci7Kd1iZ
tyler-dane
added
the
agent-automerge
Claude
tyler-dane
enabled auto-merge
October 18, 2026 00:36
Contributor
|
Boot bundle: 509.5 KB gzip (+0.0 KB vs main) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes sidebar event form usability regressions reported after #4540 (no issue filed).
What and why
When #4540 portaled the time picker menu to
document.body, the menu ended up outside.c-time-picker. That broke two things: the menu lost its theme styles (white background, narrow, so labels like "12:15 AM" wrapped), and the scroll-to-selected lookup stopped finding the menu, so it always opened at 12 AM. The picker now finds the menu through the combobox'saria-controls. The menu styles moved into react-select'sstylesobject, and the menu is sized to its content so it doesn't wrap or run off the right edge.The date field threw away a typed date on Tab or click-away, and an empty Enter showed the "IDK what to do with ''" toast. Now Enter, Tab and blur all commit a typed date that changes the day. An emptied field quietly restores the current date, and text that can't be parsed shows the toast and reverts. Focusing the input selects its text, so typing replaces it.
There is also more top padding above the delete and close icons.
Product choice: unparseable input reverts to the saved date (with the toast) instead of keeping the bad text in the field.
Verify
VERDICT: FAILfrombun run verify --strict. Neither failure comes from this diff:mainwithout this change. Every other web test passes (0 fail), and the EventForm suites pass when run on their own.bun lintpasses now.New regression tests in
EventFormDateField.test.tsx: Tab commits a typed date, blur commits a typed date, empty Enter restores the date.Generated by Claude Code