Fix performance regression in case of many inequalities - #3948
Open
unp1 wants to merge 9 commits into
Open
Conversation
unp1
force-pushed
the
bubel/fix-multcross-regression
branch
from
July 29, 2026 07:11
383fec7 to
eaedc94
Compare
unp1
enabled auto-merge
July 29, 2026 07:18
unp1
force-pushed
the
bubel/fix-multcross-regression
branch
2 times, most recently
from
July 31, 2026 04:57
607bc81 to
bc7fa72
Compare
…with many inequations Improves performance of bike by 7.5%, bet 5%, several proofs of the Jerboa case study by around 3% to 5% ,and an example from the red black case study by 75% (from 90s to 20s)
unp1
force-pushed
the
bubel/fix-multcross-regression
branch
from
July 31, 2026 05:13
bc7fa72 to
9533124
Compare
…ontains - replaces linear check by hashmap lookup
- accessing a sequent formula of sequent by index is O(n)
unp1
disabled auto-merge
July 31, 2026 15:59
Construct the map first using a normal hashmap and convert then to an immutable map
unp1
enabled auto-merge
July 31, 2026 16:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended Change
Fixes a performance regression in case of many inequations introduced due to DefOps new feature
to solve inequations via cross multiplication.
The fix saves on sthe Stipula problems 5% (bet) to 7.5% (bike), several Jerboa problems around (3% to 5%)
and on a red black case study problem 75% (90s down to 20s).
Type of pull request
Ensuring quality
Additional information and contact(s)
The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.