[pull] master from comfyanonymous:master - #106
Open
pull[bot] wants to merge 4392 commits into
Open
Conversation
Signed-off-by: bigcat88 <bigcat88@icloud.com>
…_id (#14939) When a prompt is submitted without client_id and its output nodes are served from cache, _send_cached_ui returned early before recording the cached UI outputs, so /api/jobs/{job_id} (and /history) reported success with empty outputs. Record the outputs before the client_id check.
…me in RAM (CORE-353) (CORE-351) (#14813)
Signed-off-by: bigcat88 <bigcat88@icloud.com>
Put them in the models/model_patches folder. Use the new AnimaLLLiteApply node.
Co-authored-by: Alexis Rolland <alexisrolland@hotmail.com>
…r, Video Translate and TTS nodes (#14958) * [Partner Nodes] feat(HeyGen): add Avatar, Talking Photo, Create Avatar, Video Translate and TTS nodes Signed-off-by: bigcat88 <bigcat88@icloud.com> * [Partner Nodes] fix(HeyGen): display only Avatars supported by engine Signed-off-by: bigcat88 <bigcat88@icloud.com> * [Partner Nodes] remove 4K option --------- Signed-off-by: bigcat88 <bigcat88@icloud.com> Co-authored-by: Alexis Rolland <alexisrolland@hotmail.com>
…tris and identity edit ref loras. (#14843)
Scope AGENTS.md review to @comfyanonymous, matching the existing /CODEOWNERS, /.ci/, and /.github/ meta-file entries.
…de video support, trainer video support (CORE-81) (#13588)
* FreSca: Make fresca work on multi dim
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
* fix: respect user directory for default database * refactor: use None default for --database-url instead of argv scan Per review: default --database-url to None and treat a non-None value as explicit at resolution time. Removes the sys.argv scan and the database_url_explicit attribute. database_default_path now serves directly as the legacy copy source. Adds regression tests for the unchanged no-flag default path and explicit URLs at the legacy location. * refactor: rename legacy database to .bak after copy Per review: after copying the legacy install-dir database to the effective user directory, rename the original to comfyui.db.bak so a later launch without --user-directory cannot silently fall back to a diverged copy, while keeping the file around for recovery. Also hoist the database_default_path import to module scope. * fix: guard legacy migration on existing .bak and rename before copy Per review: bail out of the legacy migration when comfyui.db.bak already exists, so only the first run migrates and later launches with a fresh --user-directory cannot grab a database another instance is using. Rename before copy so os.replace fails fast if the legacy DB is held open by a running instance. --------- Co-authored-by: guill <jacob.e.segal@gmail.com>
After the Python 3.10 EOL date of October 31 2026 we will put zero effort into keeping support for python 3.10 so everyone is recommended to upgrade to a newer version.
…el version (#15851) Signed-off-by: bigcat88 <bigcat88@icloud.com>
Comfy-aimdo 0.4.15 fixes the headroom on the NVML pressure mechanism. Some system have only NVML as the pressure out and this could cause shared VRAM spills. This bumps the headroom to 512MB. I never reproduced this issue.
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
…#15883) Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
…5929) Signed-off-by: Alexander Piskun <bigcat88@icloud.com> Co-authored-by: Purz <97489706+purzbeats@users.noreply.github.com>
This is the result of an experiment where I asked a LLM to create a better sampler for the base Anima model and gave it a lot of different things to try. I wouldn't call this revolutionary but from my basic testing it seems to be a bit better than the other samplers at lower steps so I have decided to include it in ComfyUI. For best result use it at CFG 2.0 on base Anima. It should also work on other models but I'm not sure about the optimal parameters.
Signed-off-by: bigcat88 <bigcat88@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )