fix: overlapping elements#19
Open
ohbeomho wants to merge 1 commit into
Open
Conversation
|
@ohbeomho is attempting to deploy a commit to the Jurre's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Nice, works in my fork |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIX: Overlapping elements
Sorry for my poor English.
Bug Description
If there are more than 2 rows and the last row has
less than 4 elements, it overlaps the section below.
Fixed by setting row height to
Math.ceil(list.length / 7)instead of
Math.round((list.length - 0.1) / 7) > 1 ? Math.round((list.length - 0.1) / 7) : 1Fixes: #20