Skip to content

doc: correct cubic equation - #519

Merged
franckgaga merged 1 commit into
mainfrom
doc_correciton
Nov 15, 2026
Merged

franckgaga merged 1 commit into
mainfrom
doc_correciton

Conversation

@franckgaga

@franckgaga franckgaga commented Nov 15, 2026 •

Copy link
Copy Markdown
Member

Correct a small mistake in the cubic equation of the charge balance for the pH neutralization reactor.

@franckgaga

franckgaga commented Nov 15, 2026 •

Copy link
Copy Markdown
Member Author

I will test the new commit on juliaci.yml by the way (with the setup-julia instead of juliaup step). See details here : julia-testitems/testitem-workflow#37 (comment)

@franckgaga

Copy link
Copy Markdown
Member Author

Doc deployment for the PR preview works well. Let's see for the dev doc, merging.

@franckgaga
franckgaga merged commit 568778c into main Nov 15, 2026
15 checks passed
@franckgaga
franckgaga deleted the doc_correciton branch November 15, 2026 16:47
@codecov-commenter

codecov-commenter commented Nov 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.30%. Comparing base (3ab73ae) to head (898187b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #519      +/-   ##
==========================================
- Coverage   97.41%   97.30%   -0.12%     
==========================================
  Files          28       28              
  Lines        7077     7077              
==========================================
- Hits         6894     6886       -8     
- Misses        183      191       +8     
Flag Coverage Δ
unittests 97.30% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@franckgaga

Copy link
Copy Markdown
Member Author

Dev doc deployment also work well. Seems okay the new workflow script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants