Repository navigation
doc: ModelingToolkit section in the manual now supports DAEs - #518
Merged
Merged
Conversation
ModelingToolkit section in the manual now support DAEs + pH neutralization exampleModelingToolkit section in the manual support DAEs + pH neutralization example
ModelingToolkit section in the manual support DAEs + pH neutralization exampleModelingToolkit section in the manual support DAEs
ModelingToolkit section in the manual support DAEsModelingToolkit section in the manual now supports DAEs
Member
Author
|
Let's do also a benchmark to see if the PR #516 work as expected. |
This reverts commit 05986af.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #518 +/- ##
==========================================
+ Coverage 97.35% 97.37% +0.01%
==========================================
Files 28 28
Lines 7077 7077
==========================================
+ Hits 6890 6891 +1
+ Misses 187 186 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add the support for DAEs in the "ModelingToolkit" section of the manual. The conversion function now return either a
NonLinModelorNonLinModelDAE, depending on the presence of algebraic equations.I started a section that applies the conversion functions on the pH neutralization reactor MTK model. It works well but the section only does open-loop simulation for now. I will add the support of measured disturbances before continuing this example in the manual.