Skip to content

Reduce URL percent-encoding allocations #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tanmaykm merged 1 commit into from
Sep 21, 2026
Merged

Reduce URL percent-encoding allocations #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/runtime.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1504,7 +1504,8 @@ function _escapeuri(text)
if char in 'A':'Z' || char in 'a':'z' || char in '0':'9' || char in "-_.~"
write(io, char)
else
print(io, '%', uppercase(string(byte; base = 16, pad = 2)))
write(io, UInt8('%'), codeunit("0123456789ABCDEF", (byte >> 4) + 1),
codeunit("0123456789ABCDEF", (byte & 0x0f) + 1))
end
end
return String(take!(io))
Expand Down
10 changes: 10 additions & 0 deletions test/runtime.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,16 @@
@test invoke(:_escape, reserved; allow_reserved = true) == reserved
@test invoke(:_escape, "%2F"; allow_reserved = true) == "%2F"
@test invoke(:_escape, "a b") == "a%20b"
@test invoke(:_escape, "AZaz09-_.~") == "AZaz09-_.~"
@test invoke(:_escape, "%2F") == "%252F"
@test invoke(:_escape, "α👽/\0") == "%CE%B1%F0%9F%91%BD%2F%00"
@test invoke(:_escape, SubString("prefixα 👽", 7)) == "%CE%B1%20%F0%9F%91%BD"
for byte in UInt8(0):UInt8(255)
char = Char(byte)
expected = char in "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789-_.~" ?
string(char) : "%" * uppercase(string(byte; base = 16, pad = 2))
@test invoke(:_escape, String([byte])) == expected
end
# allowReserved on a path parameter keeps slash-delimited values intact
@test invoke(:_path_parameter, "path", "opa/examples/public servers", :simple, false) ==
"opa%2Fexamples%2Fpublic%20servers"
Expand Down
Loading