fix(scanner): Resolve imports conservatively - #86
Open
reneleonhardt wants to merge 1 commit into
Open
Conversation
Owner
|
Heads up: #84 just landed on main and overlaps this PR in I test-merged main into this branch locally to scope the damage — it's small:
Your call on mechanics: happy to push the merge-up to this branch (maintainer edits are enabled), or leave the rebase to you if you'd rather keep authorship of the reconciliation. Either way this is close — nice conservative design. |
5 tasks
Co-Authored-By: GPT-5.6 Sol <codex@openai.com>
reneleonhardt
force-pushed
the
fix/import-resolution-boundaries
branch
from
July 29, 2026 09:26
66aa67f to
e4e93b6
Compare
Contributor
Author
|
Rebased onto current
This is reconciliation with PR84 only — this PR's conservative-resolution scope and behavior are unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Limit fuzzy resolution to compatible language families. Resolve Go imports only to indexed, non-test files in the current module; keep bare JS/TS packages external unless a configured alias proves an included local target.
Type of change
Verification
go test ./scanner -run '^(TestBuildFileGraphImportResolutionBoundaries|TestFilteredImportResolutionTargets)$' -count=1go test ./scanner -count=1Developed with carefully directed, manually reviewed AI assistance.
Co-Authored-By: GPT-5.6 Sol codex@openai.com