Skip to content

Fix/list translations #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
John-Paul-R merged 2 commits into from
Jul 11, 2026
Merged

Fix/list translations #394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
363e36b
bump mc version to stable to simplify testing
arnokeesman Jul 11, 2026
8aabb73
fix list command translations
arnokeesman Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ org.gradle.jvmargs=-Xmx2048M

# Fabric Properties
# check these on https://fabricmc.net/develop
minecraft_version=26.2-rc-2
minecraft_version=26.2
loader_version=0.18.3
loom_version=1.17-SNAPSHOT

Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/fibermc/essentialcommands/EssentialCommandRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ public static void register(
homeListBuilder
.requires(ECPerms.require(ECPerms.Registry.home_tp, 0))
.executes(ListCommandFactory.create(
ECText.getInstance().getString("cmd.home.list.start"),
"cmd.home.list.start",
"home tp",
HomeCommand.Suggestion::getSuggestionEntries));

Expand Down Expand Up @@ -255,7 +255,7 @@ public static void register(
warpListBuilder
.requires(ECPerms.require(ECPerms.Registry.warp_tp, 0))
.executes(ListCommandFactory.create(
ECText.getInstance().getString("cmd.warp.list.start"),
"cmd.warp.list.start",
"warp tp",
(context) -> ManagerLocator.getInstance().getWorldDataManager().getAccessibleWarps(context.getSource().getPlayerOrException()).toList(),
NamedMinecraftLocation::getName
Expand Down
6 changes: 4 additions & 2 deletions src/main/java/com/fibermc/essentialcommands/commands/ListCommandFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,12 @@ private ListCommandFactory() {}

// Specify leading response text, and supplier of list of strings/Text
public static <T> Command<CommandSourceStack> create(
String responsePreText,
String translationKey,
String commandExecText,
SuggestionListProvider<Entry<String, T>> suggestionsProvider)
{
return (CommandContext<CommandSourceStack> context) -> {
String responsePreText = ECText.getInstance().getString(translationKey);
var styleProvider = PlayerProfile.accessFromContextOrThrow(context);
Collection<Entry<String, T>> suggestionsList = suggestionsProvider.getSuggestionList(context);

Expand All @@ -46,12 +47,13 @@ public static <T> Command<CommandSourceStack> create(
}

public static <T> Command<CommandSourceStack> create(
String responsePreText,
String translationKey,
String commandExecText,
SuggestionListProvider<T> suggestionsProvider,
Function<T, String> nameAccessor)
{
return (CommandContext<CommandSourceStack> context) -> {
String responsePreText = ECText.getInstance().getString(translationKey);
var styleProvider = PlayerProfile.accessFromContextOrThrow(context);
Collection<T> suggestionsList = suggestionsProvider.getSuggestionList(context);

Expand Down