Update chat sample for the liquid glass era - #5697
Open
Sebastian Aigner (SebastianAigner) wants to merge 1 commit into
Open
Update chat sample for the liquid glass era#5697Sebastian Aigner (SebastianAigner) wants to merge 1 commit into
Sebastian Aigner (SebastianAigner) wants to merge 1 commit into
Conversation
Sebastian Aigner (SebastianAigner)
force-pushed
the
aigner-liquid-glass-chat
branch
from
August 28, 2026 04:51
eaf8ca1 to
d3f5f75
Compare
Sebastian Aigner (SebastianAigner)
force-pushed
the
aigner-liquid-glass-chat
branch
from
August 28, 2026 04:52
d3f5f75 to
84ac525
Compare
Sebastian Aigner (SebastianAigner)
requested review from
Victor Kropp (kropp)
and
a balanced review from Copilot
August 28, 2026 04:57
Copilot started reviewing on behalf of
Sebastian Aigner (SebastianAigner)
August 28, 2026 04:58
View session
There was a problem hiding this comment.
Pull request overview
Modernizes the iOS chat sample with native SwiftUI liquid-glass overlays and bottom-anchored Compose messages.
Changes:
- Adds native chat header, footer scrim, avatars, and glass controls.
- Adjusts Compose insets and message-list behavior.
- Configures tab-bar and status-bar appearance.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
main.ios.kt |
Combines system and native-overlay insets. |
Messages.kt |
Bottom-anchors and reverses message layout. |
Info.plist |
Enables application-managed status-bar styling. |
ContentView.swift |
Adds translucent tab-bar styling. |
ComposeViewControllerToSwiftUI.swift |
Passes native header inset to Compose. |
ComposeInsideSwiftUIScreen.swift |
Implements the redesigned native overlays and controls. |
Suppressed comments (2)
examples/chat/iosApp/iosApp/ComposeInsideSwiftUIScreen.swift:92
- The video-call affordance has an empty action, so every tap is guaranteed to have no effect despite the button and interactive glass styling. Connect it to the intended call behavior, or remove the interactive Button semantics if it is only decorative.
Button(action: {}) {
examples/chat/iosApp/iosApp/ComposeInsideSwiftUIScreen.swift:107
- This title/chevron control is presented and announced as actionable, but its action is empty. Provide the intended conversation-details action, or use a noninteractive styled view instead.
Button(action: {}) {
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| private struct ChatBackButton: View { | ||
| var body: some View { | ||
| Button(action: {}) { |
Member
Author
There was a problem hiding this comment.
It's just decoration; for the time being, it should stay as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the chat example with a fresh look and liquid glass controls.
The previous version looked like this on modern iOS:
(and for real comparison, back in the olden days, it looked like the following)
Release Notes
N/A